Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

led: gpio: Fix possible ZERO_SIZE_PTR pointer dereferencing error.

Browse source 
Since we cannot make sure the 'pdata->num_leds' will always be none
zero here, and then if it equals to zero, the kmemdup() will return
ZERO_SIZE_PTR, which equals to ((void *)16).

So this patch fix this with just doing the zero check before calling
kmemdup().

Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
Signed-off-by: Bryan Wu <cooloney@gmail.com>
This commit is contained in:
Xiubo Li 2014-09-28 01:57:15 -07:00 committed by Bryan Wu
parent 4cc72346f0
commit a823e76138
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/leds/leds-gpio-register.c
View file

@ -28,6 +28,9 @@ struct platform_device *__init gpio_led_register_device(
struct platform_device *ret; struct platform_device *ret;
struct gpio_led_platform_data _pdata = *pdata; struct gpio_led_platform_data _pdata = *pdata;
if (!pdata->num_leds)
return ERR_PTR(-EINVAL);
_pdata.leds = kmemdup(pdata->leds, _pdata.leds = kmemdup(pdata->leds,
pdata->num_leds * sizeof(*pdata->leds), GFP_KERNEL); pdata->num_leds * sizeof(*pdata->leds), GFP_KERNEL);
if (!_pdata.leds) if (!_pdata.leds)