Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

mmc_test: initialize mmc_test_lock statically

Browse source 
The mutex mmc_test_lock is initialized at every time mmc_test device
is probed. Probing another mmc_test device may break the mutex, if
the probe function is called while the mutex is locked.

This patch fixes it by statically initializing mmc_test_lock.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
This commit is contained in:
Akinobu Mita 2008-09-13 19:03:32 +09:00 committed by Pierre Ossman
parent 9d4e98e960
commit a650031a6b
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/mmc/card/mmc_test.c
View file

@ -1040,7 +1040,7 @@ static const struct mmc_test_case mmc_test_cases[] = {
}; };
static struct mutex mmc_test_lock; static DEFINE_MUTEX(mmc_test_lock);
static void mmc_test_run(struct mmc_test_card *test, int testcase) static void mmc_test_run(struct mmc_test_card *test, int testcase)
{ {
@ -1171,8 +1171,6 @@ static int mmc_test_probe(struct mmc_card *card)
if ((card->type != MMC_TYPE_MMC) && (card->type != MMC_TYPE_SD)) if ((card->type != MMC_TYPE_MMC) && (card->type != MMC_TYPE_SD))
return -ENODEV; return -ENODEV;
mutex_init(&mmc_test_lock);
ret = device_create_file(&card->dev, &dev_attr_test); ret = device_create_file(&card->dev, &dev_attr_test);
if (ret) if (ret)
return ret; return ret;