Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[PKT_SCHED] act_gact: division by zero

Browse source 
Not returning -EINVAL, because someone might want to use the value
zero in some future gact_prob algorithm?

Signed-off-by: Kim Nordlund <kim.nordlund@nokia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Kim Nordlund 2006-12-01 20:21:44 -08:00 committed by David S. Miller
parent 0b251df103
commit a163148c1b
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
net/sched/act_gact.c
View file

@ -48,14 +48,14 @@ static struct tcf_hashinfo gact_hash_info = {
#ifdef CONFIG_GACT_PROB #ifdef CONFIG_GACT_PROB
static int gact_net_rand(struct tcf_gact *gact) static int gact_net_rand(struct tcf_gact *gact)
{ {
if (net_random() % gact->tcfg_pval) if (!gact->tcfg_pval || net_random() % gact->tcfg_pval)
return gact->tcf_action; return gact->tcf_action;
return gact->tcfg_paction; return gact->tcfg_paction;
} }
static int gact_determ(struct tcf_gact *gact) static int gact_determ(struct tcf_gact *gact)
{ {
if (gact->tcf_bstats.packets % gact->tcfg_pval) if (!gact->tcfg_pval || gact->tcf_bstats.packets % gact->tcfg_pval)
return gact->tcf_action; return gact->tcf_action;
return gact->tcfg_paction; return gact->tcfg_paction;
} }