Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[DCCP]: Fix compiler warnings

Browse source 
may be a false warning if there always is something on ccid3hcrx_hist:

net/dccp/ccids/ccid3.c: In function 'ccid3_hc_rx_packet_recv':
net/dccp/ccids/ccid3.c:1634: warning: 'tstamp.tv_usec' may be used uninitialized in this function
net/dccp/ccids/ccid3.c:1634: warning: 'tstamp.tv_sec' may be used uninitialized in this function

const on inline functions doesn't have any effect:

net/dccp/dccp.h:64: warning: type qualifiers ignored on function return type
net/dccp/dccp.h:70: warning: type qualifiers ignored on function return type
net/dccp/dccp.h:76: warning: type qualifiers ignored on function return type

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Patrick McHardy 2005-08-14 21:05:53 -03:00 committed by David S. Miller
parent a1d3a35518
commit a10cedd4b9
2 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
net/dccp/ccids/ccid3.c
View file

@ -1634,7 +1634,7 @@ static u32 ccid3_hc_rx_calc_first_li(struct sock *sk)
struct ccid3_hc_rx_sock *hcrx = dp->dccps_hc_rx_ccid_private; struct ccid3_hc_rx_sock *hcrx = dp->dccps_hc_rx_ccid_private;
struct dccp_rx_hist_entry *entry, *next, *tail = NULL; struct dccp_rx_hist_entry *entry, *next, *tail = NULL;
u32 rtt, delta, x_recv, fval, p, tmp2; u32 rtt, delta, x_recv, fval, p, tmp2;
struct timeval tstamp, tmp_tv; struct timeval tstamp = { 0 }, tmp_tv;
int interval = 0; int interval = 0;
int win_count = 0; int win_count = 0;
int step = 0; int step = 0;

11
net/dccp/dccp.h
View file

@ -60,20 +60,19 @@ extern void dccp_time_wait(struct sock *sk, int state, int timeo);
extern struct proto dccp_v4_prot; extern struct proto dccp_v4_prot;
/* is seq1 < seq2 ? */ /* is seq1 < seq2 ? */
static inline const int before48(const u64 seq1, const u64 seq2) static inline int before48(const u64 seq1, const u64 seq2)
{ {
return (const s64)((seq1 << 16) - (seq2 << 16)) < 0; return (s64)((seq1 << 16) - (seq2 << 16)) < 0;
} }
/* is seq1 > seq2 ? */ /* is seq1 > seq2 ? */
static inline const int after48(const u64 seq1, const u64 seq2) static inline int after48(const u64 seq1, const u64 seq2)
{ {
return (const s64)((seq2 << 16) - (seq1 << 16)) < 0; return (s64)((seq2 << 16) - (seq1 << 16)) < 0;
} }
/* is seq2 <= seq1 <= seq3 ? */ /* is seq2 <= seq1 <= seq3 ? */
static inline const int between48(const u64 seq1, const u64 seq2, static inline int between48(const u64 seq1, const u64 seq2, const u64 seq3)
const u64 seq3)
{ {
return (seq3 << 16) - (seq2 << 16) >= (seq1 << 16) - (seq2 << 16); return (seq3 << 16) - (seq2 << 16) >= (seq1 << 16) - (seq2 << 16);
} }