lance: Return correct error code
Failure of kzalloc should cause the enclosing function to return -ENOMEM, not -ENODEV. Additionally, removed the following checkpatch warnings: ERROR: spaces required around that '==' (ctx:VxV) ERROR: space required before the open parenthesis '(' CHECK: Comparison to NULL could be written "!lp" Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
a813104d92
commit
a09f4af177
1 changed files with 2 additions and 2 deletions
|
@ -547,8 +547,8 @@ static int __init lance_probe1(struct net_device *dev, int ioaddr, int irq, int
|
||||||
/* Make certain the data structures used by the LANCE are aligned and DMAble. */
|
/* Make certain the data structures used by the LANCE are aligned and DMAble. */
|
||||||
|
|
||||||
lp = kzalloc(sizeof(*lp), GFP_DMA | GFP_KERNEL);
|
lp = kzalloc(sizeof(*lp), GFP_DMA | GFP_KERNEL);
|
||||||
if(lp==NULL)
|
if (!lp)
|
||||||
return -ENODEV;
|
return -ENOMEM;
|
||||||
if (lance_debug > 6) printk(" (#0x%05lx)", (unsigned long)lp);
|
if (lance_debug > 6) printk(" (#0x%05lx)", (unsigned long)lp);
|
||||||
dev->ml_priv = lp;
|
dev->ml_priv = lp;
|
||||||
lp->name = chipname;
|
lp->name = chipname;
|
||||||
|
|
Loading…
Reference in a new issue