spi: spidev: use spi_sync instead of spi_async
This has the benefit that the "optimization" of the framework in regards to spi_sync will also benefit spidev users directly and allow running spi transfers without a necessary context-switch to message-pump. Signed-off-by: Martin Sperl <kernel@martin.sperl.org> Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
parent
c517d838eb
commit
98d6f47958
1 changed files with 10 additions and 22 deletions
|
@ -95,37 +95,25 @@ MODULE_PARM_DESC(bufsiz, "data bytes in biggest supported SPI message");
|
||||||
|
|
||||||
/*-------------------------------------------------------------------------*/
|
/*-------------------------------------------------------------------------*/
|
||||||
|
|
||||||
/*
|
|
||||||
* We can't use the standard synchronous wrappers for file I/O; we
|
|
||||||
* need to protect against async removal of the underlying spi_device.
|
|
||||||
*/
|
|
||||||
static void spidev_complete(void *arg)
|
|
||||||
{
|
|
||||||
complete(arg);
|
|
||||||
}
|
|
||||||
|
|
||||||
static ssize_t
|
static ssize_t
|
||||||
spidev_sync(struct spidev_data *spidev, struct spi_message *message)
|
spidev_sync(struct spidev_data *spidev, struct spi_message *message)
|
||||||
{
|
{
|
||||||
DECLARE_COMPLETION_ONSTACK(done);
|
DECLARE_COMPLETION_ONSTACK(done);
|
||||||
int status;
|
int status;
|
||||||
|
struct spi_device *spi;
|
||||||
message->complete = spidev_complete;
|
|
||||||
message->context = &done;
|
|
||||||
|
|
||||||
spin_lock_irq(&spidev->spi_lock);
|
spin_lock_irq(&spidev->spi_lock);
|
||||||
if (spidev->spi == NULL)
|
spi = spidev->spi;
|
||||||
status = -ESHUTDOWN;
|
|
||||||
else
|
|
||||||
status = spi_async(spidev->spi, message);
|
|
||||||
spin_unlock_irq(&spidev->spi_lock);
|
spin_unlock_irq(&spidev->spi_lock);
|
||||||
|
|
||||||
if (status == 0) {
|
if (spi == NULL)
|
||||||
wait_for_completion(&done);
|
status = -ESHUTDOWN;
|
||||||
status = message->status;
|
else
|
||||||
|
status = spi_sync(spi, message);
|
||||||
|
|
||||||
if (status == 0)
|
if (status == 0)
|
||||||
status = message->actual_length;
|
status = message->actual_length;
|
||||||
}
|
|
||||||
return status;
|
return status;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue