Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[XFS] prevent panic during log recovery due to bogus op_hdr length

Browse source 
A problem was reported where a system panicked in log recovery due to a
corrupt log record. The cause of the corruption is not known but this
change will at least prevent a crash for this specific scenario. Log
recovery definitely needs some more work in this area.

SGI-PV: 974151
SGI-Modid: xfs-linux-melb:xfs-kern:30318a

Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
Signed-off-by: David Chinner <dgc@sgi.com>
Signed-off-by: Christoph Hellwig <hch@infradead.org>
This commit is contained in:
Lachlan McIlroy 2008-01-10 16:43:36 +11:00 committed by Lachlan McIlroy
parent f71354bc3a
commit 9742bb93da
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
fs/xfs/xfs_log_recover.c
View file

@ -2912,7 +2912,12 @@ xlog_recover_process_data(
xlog_recover_new_tid(&rhash[hash], tid, xlog_recover_new_tid(&rhash[hash], tid,
be64_to_cpu(rhead->h_lsn)); be64_to_cpu(rhead->h_lsn));
} else { } else {
ASSERT(dp + be32_to_cpu(ohead->oh_len) <= lp); if (dp + be32_to_cpu(ohead->oh_len) > lp) {
xlog_warn(
"XFS: xlog_recover_process_data: bad length");
WARN_ON(1);
return (XFS_ERROR(EIO));
}
flags = ohead->oh_flags & ~XLOG_END_TRANS; flags = ohead->oh_flags & ~XLOG_END_TRANS;
if (flags & XLOG_WAS_CONT_TRANS) if (flags & XLOG_WAS_CONT_TRANS)
flags &= ~XLOG_CONTINUE_TRANS; flags &= ~XLOG_CONTINUE_TRANS;