Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

staging: wilc1000: replace sem_test_disconn_block with a completion

Browse source 
Semaphore sem_test_disconn_block is used to signal completion of its
host interface message. Since the thread locking this semaphore will
have to wait, completions are the preferred mechanism and will offer
a performance improvement.

Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Tested-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Alison Schofield 2016-03-14 10:35:05 -07:00 • committed by Greg Kroah-Hartman
parent 7c8a3dcac8
commit 96adbd276e
2 changed files with 4 additions and 4 deletions
drivers/staging/wilc1000
host_interface.chost_interface.h

6
drivers/staging/wilc1000/host_interface.c
View file

@ -1857,7 +1857,7 @@ static void Handle_Disconnect(struct wilc_vif *vif)
}
}
up(&hif_drv->sem_test_disconn_block);
complete(&hif_drv->comp_test_disconn_block);
}
void wilc_resolve_disconnect_aberration(struct wilc_vif *vif)
@ -3099,7 +3099,7 @@ int wilc_disconnect(struct wilc_vif *vif, u16 reason_code)
if (result)
netdev_err(vif->ndev, "Failed to send message: disconnect\n");
down(&hif_drv->sem_test_disconn_block);
wait_for_completion(&hif_drv->comp_test_disconn_block);
return result;
}
@ -3406,7 +3406,7 @@ int wilc_init(struct net_device *dev, struct host_if_drv **hif_drv_handler)
}
sema_init(&hif_drv->sem_test_key_block, 0);
sema_init(&hif_drv->sem_test_disconn_block, 0);
init_completion(&hif_drv->comp_test_disconn_block);
init_completion(&hif_drv->comp_get_rssi);
init_completion(&hif_drv->comp_inactive_time);

2
drivers/staging/wilc1000/host_interface.h
View file

@ -276,7 +276,7 @@ struct host_if_drv {
struct mutex cfg_values_lock;
struct semaphore sem_test_key_block;
struct semaphore sem_test_disconn_block;
struct completion comp_test_disconn_block;
struct completion comp_get_rssi;
struct completion comp_inactive_time;