Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[SCSI] aic7xxx: fix ahc_done check SCB_ACTIVE for tagged transactions

Browse source 
The driver only needs to check the SCB_ACTIVE flag if the SCB is not
in the untagged queue.

If the driver is in error recovery, you may end panic'ing on a TUR
that is in the untagged queue.

Attempting to queue an ABORT message
CDB: 0x0 0x0 0x0 0x0 0x0 0x0
SCB 3 done'd twice

This patch is included in Adaptec's 6.3.11 driver on their website.

Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
This commit is contained in:
David Milburn 2008-01-25 12:16:18 -06:00 • committed by James Bottomley
parent 2adbfa333a
commit 969ceffb66
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
drivers/scsi/aic7xxx/aic7xxx_osm.c
View file

@ -1658,9 +1658,12 @@ ahc_done(struct ahc_softc *ahc, struct scb *scb)
untagged_q = &(ahc->untagged_queues[target_offset]); untagged_q = &(ahc->untagged_queues[target_offset]);
TAILQ_REMOVE(untagged_q, scb, links.tqe); TAILQ_REMOVE(untagged_q, scb, links.tqe);
BUG_ON(!TAILQ_EMPTY(untagged_q)); BUG_ON(!TAILQ_EMPTY(untagged_q));
} } else if ((scb->flags & SCB_ACTIVE) == 0) {
/*
if ((scb->flags & SCB_ACTIVE) == 0) { * Transactions aborted from the untagged queue may
* not have been dispatched to the controller, so
* only check the SCB_ACTIVE flag for tagged transactions.
*/
printf("SCB %d done'd twice\n", scb->hscb->tag); printf("SCB %d done'd twice\n", scb->hscb->tag);
ahc_dump_card_state(ahc); ahc_dump_card_state(ahc);
panic("Stopping for safety"); panic("Stopping for safety");