tunnels: harmonize cleanup done on skb on xmit path
The goal of this patch is to harmonize cleanup done on a skbuff on xmit path. Before this patch, behaviors were different depending of the tunnel type. Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
8b27f27797
commit
963a88b31d
9 changed files with 15 additions and 22 deletions
|
@ -1397,6 +1397,8 @@ static int vxlan6_xmit_skb(struct vxlan_sock *vs,
|
||||||
skb->encapsulation = 1;
|
skb->encapsulation = 1;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
skb_scrub_packet(skb, false);
|
||||||
|
|
||||||
min_headroom = LL_RESERVED_SPACE(dst->dev) + dst->header_len
|
min_headroom = LL_RESERVED_SPACE(dst->dev) + dst->header_len
|
||||||
+ VXLAN_HLEN + sizeof(struct ipv6hdr)
|
+ VXLAN_HLEN + sizeof(struct ipv6hdr)
|
||||||
+ (vlan_tx_tag_present(skb) ? VLAN_HLEN : 0);
|
+ (vlan_tx_tag_present(skb) ? VLAN_HLEN : 0);
|
||||||
|
@ -1432,7 +1434,6 @@ static int vxlan6_xmit_skb(struct vxlan_sock *vs,
|
||||||
memset(&(IPCB(skb)->opt), 0, sizeof(IPCB(skb)->opt));
|
memset(&(IPCB(skb)->opt), 0, sizeof(IPCB(skb)->opt));
|
||||||
IPCB(skb)->flags &= ~(IPSKB_XFRM_TUNNEL_SIZE | IPSKB_XFRM_TRANSFORMED |
|
IPCB(skb)->flags &= ~(IPSKB_XFRM_TUNNEL_SIZE | IPSKB_XFRM_TRANSFORMED |
|
||||||
IPSKB_REROUTED);
|
IPSKB_REROUTED);
|
||||||
skb_dst_drop(skb);
|
|
||||||
skb_dst_set(skb, dst);
|
skb_dst_set(skb, dst);
|
||||||
|
|
||||||
if (!skb_is_gso(skb) && !(dst->dev->features & NETIF_F_IPV6_CSUM)) {
|
if (!skb_is_gso(skb) && !(dst->dev->features & NETIF_F_IPV6_CSUM)) {
|
||||||
|
@ -1528,7 +1529,8 @@ int vxlan_xmit_skb(struct vxlan_sock *vs,
|
||||||
if (err)
|
if (err)
|
||||||
return err;
|
return err;
|
||||||
|
|
||||||
return iptunnel_xmit(rt, skb, src, dst, IPPROTO_UDP, tos, ttl, df);
|
return iptunnel_xmit(rt, skb, src, dst, IPPROTO_UDP, tos, ttl, df,
|
||||||
|
false);
|
||||||
}
|
}
|
||||||
EXPORT_SYMBOL_GPL(vxlan_xmit_skb);
|
EXPORT_SYMBOL_GPL(vxlan_xmit_skb);
|
||||||
|
|
||||||
|
|
|
@ -75,7 +75,6 @@ static inline void ip6tunnel_xmit(struct sk_buff *skb, struct net_device *dev)
|
||||||
struct net_device_stats *stats = &dev->stats;
|
struct net_device_stats *stats = &dev->stats;
|
||||||
int pkt_len, err;
|
int pkt_len, err;
|
||||||
|
|
||||||
nf_reset(skb);
|
|
||||||
pkt_len = skb->len;
|
pkt_len = skb->len;
|
||||||
err = ip6_local_out(skb);
|
err = ip6_local_out(skb);
|
||||||
|
|
||||||
|
|
|
@ -148,7 +148,7 @@ static inline u8 ip_tunnel_ecn_encap(u8 tos, const struct iphdr *iph,
|
||||||
int iptunnel_pull_header(struct sk_buff *skb, int hdr_len, __be16 inner_proto);
|
int iptunnel_pull_header(struct sk_buff *skb, int hdr_len, __be16 inner_proto);
|
||||||
int iptunnel_xmit(struct rtable *rt, struct sk_buff *skb,
|
int iptunnel_xmit(struct rtable *rt, struct sk_buff *skb,
|
||||||
__be32 src, __be32 dst, __u8 proto,
|
__be32 src, __be32 dst, __u8 proto,
|
||||||
__u8 tos, __u8 ttl, __be16 df);
|
__u8 tos, __u8 ttl, __be16 df, bool xnet);
|
||||||
|
|
||||||
static inline void iptunnel_xmit_stats(int err,
|
static inline void iptunnel_xmit_stats(int err,
|
||||||
struct net_device_stats *err_stats,
|
struct net_device_stats *err_stats,
|
||||||
|
|
|
@ -614,9 +614,6 @@ void ip_tunnel_xmit(struct sk_buff *skb, struct net_device *dev,
|
||||||
goto tx_error;
|
goto tx_error;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (!net_eq(tunnel->net, dev_net(dev)))
|
|
||||||
skb_scrub_packet(skb, true);
|
|
||||||
|
|
||||||
if (tunnel->err_count > 0) {
|
if (tunnel->err_count > 0) {
|
||||||
if (time_before(jiffies,
|
if (time_before(jiffies,
|
||||||
tunnel->err_time + IPTUNNEL_ERR_TIMEO)) {
|
tunnel->err_time + IPTUNNEL_ERR_TIMEO)) {
|
||||||
|
@ -655,7 +652,8 @@ void ip_tunnel_xmit(struct sk_buff *skb, struct net_device *dev,
|
||||||
}
|
}
|
||||||
|
|
||||||
err = iptunnel_xmit(rt, skb, fl4.saddr, fl4.daddr, protocol,
|
err = iptunnel_xmit(rt, skb, fl4.saddr, fl4.daddr, protocol,
|
||||||
ip_tunnel_ecn_encap(tos, inner_iph, skb), ttl, df);
|
ip_tunnel_ecn_encap(tos, inner_iph, skb), ttl, df,
|
||||||
|
!net_eq(tunnel->net, dev_net(dev)));
|
||||||
iptunnel_xmit_stats(err, &dev->stats, dev->tstats);
|
iptunnel_xmit_stats(err, &dev->stats, dev->tstats);
|
||||||
|
|
||||||
return;
|
return;
|
||||||
|
|
|
@ -48,16 +48,15 @@
|
||||||
|
|
||||||
int iptunnel_xmit(struct rtable *rt, struct sk_buff *skb,
|
int iptunnel_xmit(struct rtable *rt, struct sk_buff *skb,
|
||||||
__be32 src, __be32 dst, __u8 proto,
|
__be32 src, __be32 dst, __u8 proto,
|
||||||
__u8 tos, __u8 ttl, __be16 df)
|
__u8 tos, __u8 ttl, __be16 df, bool xnet)
|
||||||
{
|
{
|
||||||
int pkt_len = skb->len;
|
int pkt_len = skb->len;
|
||||||
struct iphdr *iph;
|
struct iphdr *iph;
|
||||||
int err;
|
int err;
|
||||||
|
|
||||||
nf_reset(skb);
|
skb_scrub_packet(skb, xnet);
|
||||||
secpath_reset(skb);
|
|
||||||
skb->rxhash = 0;
|
skb->rxhash = 0;
|
||||||
skb_dst_drop(skb);
|
|
||||||
skb_dst_set(skb, &rt->dst);
|
skb_dst_set(skb, &rt->dst);
|
||||||
memset(IPCB(skb), 0, sizeof(*IPCB(skb)));
|
memset(IPCB(skb), 0, sizeof(*IPCB(skb)));
|
||||||
|
|
||||||
|
|
|
@ -694,6 +694,8 @@ static netdev_tx_t ip6gre_xmit2(struct sk_buff *skb,
|
||||||
tunnel->err_count = 0;
|
tunnel->err_count = 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
skb_scrub_packet(skb, !net_eq(tunnel->net, dev_net(dev)));
|
||||||
|
|
||||||
max_headroom = LL_RESERVED_SPACE(tdev) + gre_hlen + dst->header_len;
|
max_headroom = LL_RESERVED_SPACE(tdev) + gre_hlen + dst->header_len;
|
||||||
|
|
||||||
if (skb_headroom(skb) < max_headroom || skb_shared(skb) ||
|
if (skb_headroom(skb) < max_headroom || skb_shared(skb) ||
|
||||||
|
@ -710,8 +712,6 @@ static netdev_tx_t ip6gre_xmit2(struct sk_buff *skb,
|
||||||
skb = new_skb;
|
skb = new_skb;
|
||||||
}
|
}
|
||||||
|
|
||||||
skb_dst_drop(skb);
|
|
||||||
|
|
||||||
if (fl6->flowi6_mark) {
|
if (fl6->flowi6_mark) {
|
||||||
skb_dst_set(skb, dst);
|
skb_dst_set(skb, dst);
|
||||||
ndst = NULL;
|
ndst = NULL;
|
||||||
|
|
|
@ -1001,8 +1001,7 @@ static int ip6_tnl_xmit2(struct sk_buff *skb,
|
||||||
goto tx_err_dst_release;
|
goto tx_err_dst_release;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (!net_eq(t->net, dev_net(dev)))
|
skb_scrub_packet(skb, !net_eq(t->net, dev_net(dev)));
|
||||||
skb_scrub_packet(skb, true);
|
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* Okay, now see if we can stuff it in the buffer as-is.
|
* Okay, now see if we can stuff it in the buffer as-is.
|
||||||
|
@ -1021,7 +1020,6 @@ static int ip6_tnl_xmit2(struct sk_buff *skb,
|
||||||
consume_skb(skb);
|
consume_skb(skb);
|
||||||
skb = new_skb;
|
skb = new_skb;
|
||||||
}
|
}
|
||||||
skb_dst_drop(skb);
|
|
||||||
if (fl6->flowi6_mark) {
|
if (fl6->flowi6_mark) {
|
||||||
skb_dst_set(skb, dst);
|
skb_dst_set(skb, dst);
|
||||||
ndst = NULL;
|
ndst = NULL;
|
||||||
|
|
|
@ -860,9 +860,6 @@ static netdev_tx_t ipip6_tunnel_xmit(struct sk_buff *skb,
|
||||||
tunnel->err_count = 0;
|
tunnel->err_count = 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (!net_eq(tunnel->net, dev_net(dev)))
|
|
||||||
skb_scrub_packet(skb, true);
|
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* Okay, now see if we can stuff it in the buffer as-is.
|
* Okay, now see if we can stuff it in the buffer as-is.
|
||||||
*/
|
*/
|
||||||
|
@ -889,7 +886,7 @@ static netdev_tx_t ipip6_tunnel_xmit(struct sk_buff *skb,
|
||||||
tos = INET_ECN_encapsulate(tos, ipv6_get_dsfield(iph6));
|
tos = INET_ECN_encapsulate(tos, ipv6_get_dsfield(iph6));
|
||||||
|
|
||||||
err = iptunnel_xmit(rt, skb, fl4.saddr, fl4.daddr, IPPROTO_IPV6, tos,
|
err = iptunnel_xmit(rt, skb, fl4.saddr, fl4.daddr, IPPROTO_IPV6, tos,
|
||||||
ttl, df);
|
ttl, df, !net_eq(tunnel->net, dev_net(dev)));
|
||||||
iptunnel_xmit_stats(err, &dev->stats, dev->tstats);
|
iptunnel_xmit_stats(err, &dev->stats, dev->tstats);
|
||||||
return NETDEV_TX_OK;
|
return NETDEV_TX_OK;
|
||||||
|
|
||||||
|
|
|
@ -179,7 +179,7 @@ static int gre_tnl_send(struct vport *vport, struct sk_buff *skb)
|
||||||
return iptunnel_xmit(rt, skb, fl.saddr,
|
return iptunnel_xmit(rt, skb, fl.saddr,
|
||||||
OVS_CB(skb)->tun_key->ipv4_dst, IPPROTO_GRE,
|
OVS_CB(skb)->tun_key->ipv4_dst, IPPROTO_GRE,
|
||||||
OVS_CB(skb)->tun_key->ipv4_tos,
|
OVS_CB(skb)->tun_key->ipv4_tos,
|
||||||
OVS_CB(skb)->tun_key->ipv4_ttl, df);
|
OVS_CB(skb)->tun_key->ipv4_ttl, df, false);
|
||||||
err_free_rt:
|
err_free_rt:
|
||||||
ip_rt_put(rt);
|
ip_rt_put(rt);
|
||||||
error:
|
error:
|
||||||
|
|
Loading…
Reference in a new issue