Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[PATCH] i4l: memory leak fix for sc_ioctl().

Browse source 
Fix leak of `rcvmsg' in sc_ioctl().

There are two returns in the switch in sc_ioctl (the SCIOCSTART case) that
may leak `rcvmsg'.  This patch fixes that by adding a kfree() call at the
beginning of that case.

Bug found by the coverity checker as #1098

Eric Sesterhenn send me a patch to fix the leak(s) by adding 2 kfree()
calls before the returns, I changed that into just a single call at the
beginning.

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Cc: Karsten Keil <kkeil@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Jesper Juhl 2006-06-23 02:05:27 -07:00 committed by Linus Torvalds
parent 2eebb1925d
commit 94a6735cd6
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
drivers/isdn/sc/ioctl.c
View file

@ -97,6 +97,7 @@ int sc_ioctl(int card, scs_ioctl *data)
case SCIOCSTART: case SCIOCSTART:
{ {
kfree(rcvmsg);
pr_debug("%s: SCIOSTART: ioctl received\n", pr_debug("%s: SCIOSTART: ioctl received\n",
sc_adapter[card]->devicename); sc_adapter[card]->devicename);
if(sc_adapter[card]->EngineUp) { if(sc_adapter[card]->EngineUp) {