Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

memstick: move the dereference below the NULL test

Browse source 
The dereference should be moved below the NULL test.

spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Cc: Maxim Levitsky <maximlevitsky@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Wei Yongjun 2013-02-27 17:05:46 -08:00 committed by Linus Torvalds
parent 507063b2a4
commit 940da353a8
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/memstick/host/r592.c
View file

@ -454,7 +454,7 @@ static int r592_transfer_fifo_pio(struct r592_device *dev)
/* Executes one TPC (data is read/written from small or large fifo) */ /* Executes one TPC (data is read/written from small or large fifo) */
static void r592_execute_tpc(struct r592_device *dev) static void r592_execute_tpc(struct r592_device *dev)
{ {
bool is_write = dev->req->tpc >= MS_TPC_SET_RW_REG_ADRS; bool is_write;
int len, error; int len, error;
u32 status, reg; u32 status, reg;
@ -463,6 +463,7 @@ static void r592_execute_tpc(struct r592_device *dev)
return; return;
} }
is_write = dev->req->tpc >= MS_TPC_SET_RW_REG_ADRS;
len = dev->req->long_data ? len = dev->req->long_data ?
dev->req->sg.length : dev->req->data_len; dev->req->sg.length : dev->req->data_len;