Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[NETFILTER]: x_tables: small check_entry & module_refcount cleanup

Browse source 
While standard_target has target->me == NULL, module_put() should be
called for it as for others, because there were try_module_get() before.

Signed-off-by: Dmitry Mishin <dim@openvz.org>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Dmitry Mishin 2006-09-20 12:00:21 -07:00 committed by David S. Miller
parent 9123de2c04
commit 90d47db4a0
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
net/ipv4/netfilter/arp_tables.c
View file

@ -485,7 +485,7 @@ static inline int check_entry(struct arpt_entry *e, const char *name, unsigned i
if (t->u.kernel.target == &arpt_standard_target) { if (t->u.kernel.target == &arpt_standard_target) {
if (!standard_check(t, size)) { if (!standard_check(t, size)) {
ret = -EINVAL; ret = -EINVAL;
goto out; goto err;
} }
} else if (t->u.kernel.target->checkentry } else if (t->u.kernel.target->checkentry
&& !t->u.kernel.target->checkentry(name, e, target, t->data, && !t->u.kernel.target->checkentry(name, e, target, t->data,

2
net/ipv4/netfilter/ip_tables.c
View file

@ -573,7 +573,7 @@ check_entry(struct ipt_entry *e, const char *name, unsigned int size,
if (t->u.kernel.target == &ipt_standard_target) { if (t->u.kernel.target == &ipt_standard_target) {
if (!standard_check(t, size)) { if (!standard_check(t, size)) {
ret = -EINVAL; ret = -EINVAL;
goto cleanup_matches; goto err;
} }
} else if (t->u.kernel.target->checkentry } else if (t->u.kernel.target->checkentry
&& !t->u.kernel.target->checkentry(name, e, target, t->data, && !t->u.kernel.target->checkentry(name, e, target, t->data,

2
net/ipv6/netfilter/ip6_tables.c
View file

@ -610,7 +610,7 @@ check_entry(struct ip6t_entry *e, const char *name, unsigned int size,
if (t->u.kernel.target == &ip6t_standard_target) { if (t->u.kernel.target == &ip6t_standard_target) {
if (!standard_check(t, size)) { if (!standard_check(t, size)) {
ret = -EINVAL; ret = -EINVAL;
goto cleanup_matches; goto err;
} }
} else if (t->u.kernel.target->checkentry } else if (t->u.kernel.target->checkentry
&& !t->u.kernel.target->checkentry(name, e, target, t->data, && !t->u.kernel.target->checkentry(name, e, target, t->data,