Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

idr: Fix idr_alloc_u32 on 32-bit systems

Browse source 
[ Upstream commit b7e9728f3d7fc5c5c8508d99f1675212af5cfd49 ]

Attempting to allocate an entry at 0xffffffff when one is already
present would succeed in allocating one at 2^32, which would confuse
everything.  Return -ENOSPC in this case, as expected.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Matthew Wilcox (Oracle) 2019-11-02 00:25:08 -04:00 committed by Greg Kroah-Hartman
parent 88358c7610
commit 8ef58b82d1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/radix-tree.c
View file

@ -2172,7 +2172,7 @@ void __rcu **idr_get_free(struct radix_tree_root *root,
offset = radix_tree_find_next_bit(node, IDR_FREE, offset = radix_tree_find_next_bit(node, IDR_FREE,
offset + 1); offset + 1);
start = next_index(start, node, offset); start = next_index(start, node, offset);
if (start > max) if (start > max || start == 0)
return ERR_PTR(-ENOSPC); return ERR_PTR(-ENOSPC);
while (offset == RADIX_TREE_MAP_SIZE) { while (offset == RADIX_TREE_MAP_SIZE) {
offset = node->offset + 1; offset = node->offset + 1;