Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[ATM]: [he] initialize lock and tasklet earlier

Browse source 
if you are lucky (unlucky?) enough to have shared interrupts, the
interrupt handler can be called before the tasklet and lock are ready
for use.

Signed-off-by: chas williams <chas@cmf.nrl.navy.mil>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
chas williams 2007-11-27 11:03:16 +08:00 committed by Herbert Xu
parent 3660019e5f
commit 8a8037ac9d
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
drivers/atm/he.c
View file

@ -394,6 +394,11 @@ he_init_one(struct pci_dev *pci_dev, const struct pci_device_id *pci_ent)
he_dev->atm_dev->dev_data = he_dev; he_dev->atm_dev->dev_data = he_dev;
atm_dev->dev_data = he_dev; atm_dev->dev_data = he_dev;
he_dev->number = atm_dev->number; he_dev->number = atm_dev->number;
#ifdef USE_TASKLET
tasklet_init(&he_dev->tasklet, he_tasklet, (unsigned long) he_dev);
#endif
spin_lock_init(&he_dev->global_lock);
if (he_start(atm_dev)) { if (he_start(atm_dev)) {
he_stop(he_dev); he_stop(he_dev);
err = -ENODEV; err = -ENODEV;
@ -1173,11 +1178,6 @@ he_start(struct atm_dev *dev)
if ((err = he_init_irq(he_dev)) != 0) if ((err = he_init_irq(he_dev)) != 0)
return err; return err;
#ifdef USE_TASKLET
tasklet_init(&he_dev->tasklet, he_tasklet, (unsigned long) he_dev);
#endif
spin_lock_init(&he_dev->global_lock);
/* 4.11 enable pci bus controller state machines */ /* 4.11 enable pci bus controller state machines */
host_cntl |= (OUTFF_ENB | CMDFF_ENB | host_cntl |= (OUTFF_ENB | CMDFF_ENB |
QUICK_RD_RETRY | QUICK_WR_RETRY | PERR_INT_ENB); QUICK_RD_RETRY | QUICK_WR_RETRY | PERR_INT_ENB);