Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

eCryptfs: release mutex on hash error path

Browse source 
Release the crypt_stat hash mutex on allocation error. Check for error
conditions when doing crypto hash calls.

Signed-off-by: Michael Halcrow <mhalcrow@us.ibm.com>
Reported-by: Kazuki Ohta <kazuki.ohta@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Michael Halcrow 2007-11-05 14:51:04 -08:00 committed by Linus Torvalds
parent 778d1a2bd4
commit 8a29f2b028
1 changed files with 22 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
fs/ecryptfs/crypto.c
View file

@ -115,11 +115,29 @@ static int ecryptfs_calculate_md5(char *dst,
} }
crypt_stat->hash_tfm = desc.tfm; crypt_stat->hash_tfm = desc.tfm;
} }
crypto_hash_init(&desc); rc = crypto_hash_init(&desc);
crypto_hash_update(&desc, &sg, len); if (rc) {
crypto_hash_final(&desc, dst); printk(KERN_ERR
mutex_unlock(&crypt_stat->cs_hash_tfm_mutex); "%s: Error initializing crypto hash; rc = [%d]\n",
__FUNCTION__, rc);
goto out;
}
rc = crypto_hash_update(&desc, &sg, len);
if (rc) {
printk(KERN_ERR
"%s: Error updating crypto hash; rc = [%d]\n",
__FUNCTION__, rc);
goto out;
}
rc = crypto_hash_final(&desc, dst);
if (rc) {
printk(KERN_ERR
"%s: Error finalizing crypto hash; rc = [%d]\n",
__FUNCTION__, rc);
goto out;
}
out: out:
mutex_unlock(&crypt_stat->cs_hash_tfm_mutex);
return rc; return rc;
} }