Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

i2o: check return code from put_user()

Browse source 
Check return value of put_user() and return -EFAULT if it failed.
Original comment "We did a get user...so assuming mem is ok...is this
bad?" is incorrect because memory can be read only.

Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Kulikov Vasiliy 2010-08-10 18:02:04 -07:00 committed by Linus Torvalds
parent d929dc2bfd
commit 89596f20bb
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
drivers/message/i2o/i2o_config.c
View file

@ -111,9 +111,9 @@ static int i2o_cfg_gethrt(unsigned long arg)
len = 8 + ((hrt->entry_len * hrt->num_entries) << 2); len = 8 + ((hrt->entry_len * hrt->num_entries) << 2);
/* We did a get user...so assuming mem is ok...is this bad? */ if (put_user(len, kcmd.reslen))
put_user(len, kcmd.reslen); ret = -EFAULT;
if (len > reslen) else if (len > reslen)
ret = -ENOBUFS; ret = -ENOBUFS;
else if (copy_to_user(kcmd.resbuf, (void *)hrt, len)) else if (copy_to_user(kcmd.resbuf, (void *)hrt, len))
ret = -EFAULT; ret = -EFAULT;
@ -147,8 +147,9 @@ static int i2o_cfg_getlct(unsigned long arg)
lct = (i2o_lct *) c->lct; lct = (i2o_lct *) c->lct;
len = (unsigned int)lct->table_size << 2; len = (unsigned int)lct->table_size << 2;
put_user(len, kcmd.reslen); if (put_user(len, kcmd.reslen))
if (len > reslen) ret = -EFAULT;
else if (len > reslen)
ret = -ENOBUFS; ret = -ENOBUFS;
else if (copy_to_user(kcmd.resbuf, lct, len)) else if (copy_to_user(kcmd.resbuf, lct, len))
ret = -EFAULT; ret = -EFAULT;
@ -208,8 +209,9 @@ static int i2o_cfg_parms(unsigned long arg, unsigned int type)
return -EAGAIN; return -EAGAIN;
} }
put_user(len, kcmd.reslen); if (put_user(len, kcmd.reslen))
if (len > reslen) ret = -EFAULT;
else if (len > reslen)
ret = -ENOBUFS; ret = -ENOBUFS;
else if (copy_to_user(kcmd.resbuf, res, len)) else if (copy_to_user(kcmd.resbuf, res, len))
ret = -EFAULT; ret = -EFAULT;