[PATCH] fuse: fix compile without CONFIG_BLOCK
Randy Dunlap wote: > Should FUSE depend on BLOCK? Without that and with BLOCK=n, I get: > > inode.c:(.text+0x3acc5): undefined reference to `sb_set_blocksize' > inode.c:(.text+0x3a393): undefined reference to `get_sb_bdev' > fs/built-in.o:(.data+0xd718): undefined reference to `kill_block_super Most fuse filesystems work fine without block device support, so I think a better solution is to disable the 'fuseblk' filesystem type if BLOCK=n. Signed-off-by: Miklos Szeredi <miklos@szeredi.hu> Acked-by: Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
parent
0ec7ca41f6
commit
875d95ec9e
1 changed files with 33 additions and 10 deletions
|
@ -535,8 +535,10 @@ static int fuse_fill_super(struct super_block *sb, void *data, int silent)
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
|
|
||||||
if (is_bdev) {
|
if (is_bdev) {
|
||||||
|
#ifdef CONFIG_BLOCK
|
||||||
if (!sb_set_blocksize(sb, d.blksize))
|
if (!sb_set_blocksize(sb, d.blksize))
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
|
#endif
|
||||||
} else {
|
} else {
|
||||||
sb->s_blocksize = PAGE_CACHE_SIZE;
|
sb->s_blocksize = PAGE_CACHE_SIZE;
|
||||||
sb->s_blocksize_bits = PAGE_CACHE_SHIFT;
|
sb->s_blocksize_bits = PAGE_CACHE_SHIFT;
|
||||||
|
@ -629,6 +631,14 @@ static int fuse_get_sb(struct file_system_type *fs_type,
|
||||||
return get_sb_nodev(fs_type, flags, raw_data, fuse_fill_super, mnt);
|
return get_sb_nodev(fs_type, flags, raw_data, fuse_fill_super, mnt);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
static struct file_system_type fuse_fs_type = {
|
||||||
|
.owner = THIS_MODULE,
|
||||||
|
.name = "fuse",
|
||||||
|
.get_sb = fuse_get_sb,
|
||||||
|
.kill_sb = kill_anon_super,
|
||||||
|
};
|
||||||
|
|
||||||
|
#ifdef CONFIG_BLOCK
|
||||||
static int fuse_get_sb_blk(struct file_system_type *fs_type,
|
static int fuse_get_sb_blk(struct file_system_type *fs_type,
|
||||||
int flags, const char *dev_name,
|
int flags, const char *dev_name,
|
||||||
void *raw_data, struct vfsmount *mnt)
|
void *raw_data, struct vfsmount *mnt)
|
||||||
|
@ -637,13 +647,6 @@ static int fuse_get_sb_blk(struct file_system_type *fs_type,
|
||||||
mnt);
|
mnt);
|
||||||
}
|
}
|
||||||
|
|
||||||
static struct file_system_type fuse_fs_type = {
|
|
||||||
.owner = THIS_MODULE,
|
|
||||||
.name = "fuse",
|
|
||||||
.get_sb = fuse_get_sb,
|
|
||||||
.kill_sb = kill_anon_super,
|
|
||||||
};
|
|
||||||
|
|
||||||
static struct file_system_type fuseblk_fs_type = {
|
static struct file_system_type fuseblk_fs_type = {
|
||||||
.owner = THIS_MODULE,
|
.owner = THIS_MODULE,
|
||||||
.name = "fuseblk",
|
.name = "fuseblk",
|
||||||
|
@ -652,6 +655,26 @@ static struct file_system_type fuseblk_fs_type = {
|
||||||
.fs_flags = FS_REQUIRES_DEV,
|
.fs_flags = FS_REQUIRES_DEV,
|
||||||
};
|
};
|
||||||
|
|
||||||
|
static inline int register_fuseblk(void)
|
||||||
|
{
|
||||||
|
return register_filesystem(&fuseblk_fs_type);
|
||||||
|
}
|
||||||
|
|
||||||
|
static inline void unregister_fuseblk(void)
|
||||||
|
{
|
||||||
|
unregister_filesystem(&fuseblk_fs_type);
|
||||||
|
}
|
||||||
|
#else
|
||||||
|
static inline int register_fuseblk(void)
|
||||||
|
{
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
static inline void unregister_fuseblk(void)
|
||||||
|
{
|
||||||
|
}
|
||||||
|
#endif
|
||||||
|
|
||||||
static decl_subsys(fuse, NULL, NULL);
|
static decl_subsys(fuse, NULL, NULL);
|
||||||
static decl_subsys(connections, NULL, NULL);
|
static decl_subsys(connections, NULL, NULL);
|
||||||
|
|
||||||
|
@ -673,7 +696,7 @@ static int __init fuse_fs_init(void)
|
||||||
if (err)
|
if (err)
|
||||||
goto out;
|
goto out;
|
||||||
|
|
||||||
err = register_filesystem(&fuseblk_fs_type);
|
err = register_fuseblk();
|
||||||
if (err)
|
if (err)
|
||||||
goto out_unreg;
|
goto out_unreg;
|
||||||
|
|
||||||
|
@ -688,7 +711,7 @@ static int __init fuse_fs_init(void)
|
||||||
return 0;
|
return 0;
|
||||||
|
|
||||||
out_unreg2:
|
out_unreg2:
|
||||||
unregister_filesystem(&fuseblk_fs_type);
|
unregister_fuseblk();
|
||||||
out_unreg:
|
out_unreg:
|
||||||
unregister_filesystem(&fuse_fs_type);
|
unregister_filesystem(&fuse_fs_type);
|
||||||
out:
|
out:
|
||||||
|
@ -698,7 +721,7 @@ static int __init fuse_fs_init(void)
|
||||||
static void fuse_fs_cleanup(void)
|
static void fuse_fs_cleanup(void)
|
||||||
{
|
{
|
||||||
unregister_filesystem(&fuse_fs_type);
|
unregister_filesystem(&fuse_fs_type);
|
||||||
unregister_filesystem(&fuseblk_fs_type);
|
unregister_fuseblk();
|
||||||
kmem_cache_destroy(fuse_inode_cachep);
|
kmem_cache_destroy(fuse_inode_cachep);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue