Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

libertas: clean up is_command_allowed_in_ps()

Browse source 
Total overkill to have an array when there's only one command in it.

Signed-off-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Dan Williams 2007-12-10 15:24:47 -05:00 committed by David S. Miller
parent b31d8b90dc
commit 852e1f2a26
1 changed files with 9 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
drivers/net/wireless/libertas/cmd.c
View file

@ -19,26 +19,20 @@ void lbs_set_cmd_ctrl_node(struct lbs_private *priv,
u16 wait_option, void *pdata_buf); u16 wait_option, void *pdata_buf);
static u16 commands_allowed_in_ps[] = {
CMD_802_11_RSSI,
};
/** /**
* @brief This function checks if the commans is allowed * @brief Checks whether a command is allowed in Power Save mode
* in PS mode not.
* *
* @param command the command ID * @param command the command ID
* @return TRUE or FALSE * @return 1 if allowed, 0 if not allowed
*/ */
static u8 is_command_allowed_in_ps(__le16 command) static u8 is_command_allowed_in_ps(u16 cmd)
{ {
int i; switch (cmd) {
case CMD_802_11_RSSI:
for (i = 0; i < ARRAY_SIZE(commands_allowed_in_ps); i++) { return 1;
if (command == cpu_to_le16(commands_allowed_in_ps[i])) default:
return 1; break;
} }
return 0; return 0;
} }
@ -1715,7 +1709,7 @@ int lbs_execute_next_command(struct lbs_private *priv)
if (cmdnode) { if (cmdnode) {
cmdptr = (struct cmd_ds_command *)cmdnode->bufvirtualaddr; cmdptr = (struct cmd_ds_command *)cmdnode->bufvirtualaddr;
if (is_command_allowed_in_ps(cmdptr->command)) { if (is_command_allowed_in_ps(le16_to_cpu(cmdptr->command))) {
if ((priv->psstate == PS_STATE_SLEEP) || if ((priv->psstate == PS_STATE_SLEEP) ||
(priv->psstate == PS_STATE_PRE_SLEEP)) { (priv->psstate == PS_STATE_PRE_SLEEP)) {
lbs_deb_host( lbs_deb_host(