Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

iommu/tegra-smmu: Fix return value check in tegra_smmu_group_get()

Browse source 
In case of error, the function iommu_group_alloc() returns ERR_PTR() and
never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().

Fixes: 7f4c9176f7 ("iommu/tegra: Allow devices to be grouped")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
This commit is contained in:
Wei Yongjun 2017-12-20 03:06:09 +00:00 • committed by Thierry Reding
parent 7f4c9176f7
commit 83476bfaf6
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/iommu/tegra-smmu.c
View file

@ -832,7 +832,7 @@ static struct iommu_group *tegra_smmu_group_get(struct tegra_smmu *smmu,
group->soc = soc; group->soc = soc;
group->group = iommu_group_alloc(); group->group = iommu_group_alloc();
if (!group->group) { if (IS_ERR(group->group)) {
devm_kfree(smmu->dev, group); devm_kfree(smmu->dev, group);
mutex_unlock(&smmu->lock); mutex_unlock(&smmu->lock);
return NULL; return NULL;