Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

serial: fixup /proc/tty/driver/serial after proc_fops conversion

Browse source 
"struct tty_driver *" lies in m->private not in v which is
SEQ_TOKEN_START which is 1 which is enough to trigger NULL dereference
next line:

	BUG: unable to handle kernel NULL pointer dereference at 000000ad
	IP: [<c040d689>] uart_proc_show+0xe/0x2b0

Noticed by Linus.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Alexey Dobriyan 2009-04-02 01:30:04 +04:00 committed by Linus Torvalds
parent 8b53ef33d9
commit 833bb3046b
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/serial/serial_core.c
View file

@ -1765,7 +1765,7 @@ static void uart_line_info(struct seq_file *m, struct uart_driver *drv, int i)
static int uart_proc_show(struct seq_file *m, void *v) static int uart_proc_show(struct seq_file *m, void *v)
{ {
struct tty_driver *ttydrv = v; struct tty_driver *ttydrv = m->private;
struct uart_driver *drv = ttydrv->driver_state; struct uart_driver *drv = ttydrv->driver_state;
int i; int i;