Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

seltests/zram: fix syntax error

Browse source 
Not all shells define a variable UID. This is a bash and zsh feature only.
In other shells, the UID variable is not defined, so here test command
expands to [ != 0 ] which is a syntax error.

Without this patch:
root@HGH1000007090:/opt/work/linux/tools/testing/selftests/zram# sh zram.sh
zram.sh: 8: [: !=: unexpected operator
zram.sh : No zram.ko module or /dev/zram0 device file not found
zram.sh : CONFIG_ZRAM is not set

With this patch:
root@HGH1000007090:/opt/work/linux/tools/testing/selftests/zram# sh ./zram.sh
zram.sh : No zram.ko module or /dev/zram0 device file not found
zram.sh : CONFIG_ZRAM is not set

Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com>
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
This commit is contained in:
Zhang Zhen 2015-09-14 12:13:27 +08:00 committed by Shuah Khan
parent 6ff33f3902
commit 7ef7cc9fdf
2 changed files with 3 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
tools/testing/selftests/zram/zram.sh
View file

@ -1,15 +1,7 @@
#!/bin/bash #!/bin/bash
TCID="zram.sh" TCID="zram.sh"
check_prereqs() . ./zram_lib.sh
{
local msg="skip all tests:"
if [ $UID != 0 ]; then
echo $msg must be run as root >&2
exit 0
fi
}
run_zram () { run_zram () {
echo "--------------------" echo "--------------------"

3
tools/testing/selftests/zram/zram_lib.sh
View file

@ -23,8 +23,9 @@ trap INT
check_prereqs() check_prereqs()
{ {
local msg="skip all tests:" local msg="skip all tests:"
local uid=$(id -u)
if [ $UID != 0 ]; then if [ $uid -ne 0 ]; then
echo $msg must be run as root >&2 echo $msg must be run as root >&2
exit 0 exit 0
fi fi