Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[patch 4/5] vfs: reuse local variable in vfs_link()

Browse source 
Why not reuse "inode" which is assigned as

  struct inode *inode = old_dentry->d_inode;

in the beginning of vfs_link() ?

Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
This commit is contained in:
Tetsuo Handa 2008-06-24 16:50:15 +02:00 committed by Al Viro
parent 2f1936b877
commit 7e79eedb3b
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
fs/namei.c
View file

@ -2524,19 +2524,19 @@ int vfs_link(struct dentry *old_dentry, struct inode *dir, struct dentry *new_de
return -EPERM; return -EPERM;
if (!dir->i_op || !dir->i_op->link) if (!dir->i_op || !dir->i_op->link)
return -EPERM; return -EPERM;
if (S_ISDIR(old_dentry->d_inode->i_mode)) if (S_ISDIR(inode->i_mode))
return -EPERM; return -EPERM;
error = security_inode_link(old_dentry, dir, new_dentry); error = security_inode_link(old_dentry, dir, new_dentry);
if (error) if (error)
return error; return error;
mutex_lock(&old_dentry->d_inode->i_mutex); mutex_lock(&inode->i_mutex);
DQUOT_INIT(dir); DQUOT_INIT(dir);
error = dir->i_op->link(old_dentry, dir, new_dentry); error = dir->i_op->link(old_dentry, dir, new_dentry);
mutex_unlock(&old_dentry->d_inode->i_mutex); mutex_unlock(&inode->i_mutex);
if (!error) if (!error)
fsnotify_link(dir, old_dentry->d_inode, new_dentry); fsnotify_link(dir, inode, new_dentry);
return error; return error;
} }