Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

CRISv10: remove redundant tests on unsigned

Browse source 
Since dmanr is unsigned, negatives are wrapped and caught by the other test.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
This commit is contained in:
Roel Kluin 2009-06-23 10:04:14 +02:00 committed by Jesper Nilsson
parent 768c31495a
commit 7b994836f0
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
arch/cris/arch-v10/kernel/dma.c
View file

@ -24,7 +24,7 @@ int cris_request_dma(unsigned int dmanr, const char * device_id,
unsigned long int gens; unsigned long int gens;
int fail = -EINVAL; int fail = -EINVAL;
if ((dmanr < 0) || (dmanr >= MAX_DMA_CHANNELS)) { if (dmanr >= MAX_DMA_CHANNELS) {
printk(KERN_CRIT "cris_request_dma: invalid DMA channel %u\n", dmanr); printk(KERN_CRIT "cris_request_dma: invalid DMA channel %u\n", dmanr);
return -EINVAL; return -EINVAL;
} }
@ -213,7 +213,7 @@ int cris_request_dma(unsigned int dmanr, const char * device_id,
void cris_free_dma(unsigned int dmanr, const char * device_id) void cris_free_dma(unsigned int dmanr, const char * device_id)
{ {
unsigned long flags; unsigned long flags;
if ((dmanr < 0) || (dmanr >= MAX_DMA_CHANNELS)) { if (dmanr >= MAX_DMA_CHANNELS) {
printk(KERN_CRIT "cris_free_dma: invalid DMA channel %u\n", dmanr); printk(KERN_CRIT "cris_free_dma: invalid DMA channel %u\n", dmanr);
return; return;
} }