perf build-id: Move the routine to find DSOs with hits to the lib
Because 'perf record' will have to find the build-ids in after we stop recording, so as to reduce even more the impact in the workload while we do the measurement. Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Frédéric Weisbecker <fweisbec@gmail.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Paul Mackerras <paulus@samba.org> LKML-Reference: <1265223128-11786-5-git-send-email-acme@infradead.org> Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
parent
8ad94c6052
commit
7b2567c1f5
4 changed files with 51 additions and 29 deletions
|
@ -357,6 +357,7 @@ LIB_H += util/include/asm/uaccess.h
|
|||
LIB_H += perf.h
|
||||
LIB_H += util/cache.h
|
||||
LIB_H += util/callchain.h
|
||||
LIB_H += util/build-id.h
|
||||
LIB_H += util/debug.h
|
||||
LIB_H += util/debugfs.h
|
||||
LIB_H += util/event.h
|
||||
|
@ -390,6 +391,7 @@ LIB_H += util/probe-event.h
|
|||
|
||||
LIB_OBJS += util/abspath.o
|
||||
LIB_OBJS += util/alias.o
|
||||
LIB_OBJS += util/build-id.o
|
||||
LIB_OBJS += util/config.o
|
||||
LIB_OBJS += util/ctype.o
|
||||
LIB_OBJS += util/debugfs.o
|
||||
|
|
|
@ -8,6 +8,7 @@
|
|||
*/
|
||||
#include "builtin.h"
|
||||
#include "perf.h"
|
||||
#include "util/build-id.h"
|
||||
#include "util/cache.h"
|
||||
#include "util/debug.h"
|
||||
#include "util/parse-options.h"
|
||||
|
@ -33,34 +34,6 @@ static const struct option options[] = {
|
|||
OPT_END()
|
||||
};
|
||||
|
||||
static int build_id_list__process_event(event_t *event,
|
||||
struct perf_session *session)
|
||||
{
|
||||
struct addr_location al;
|
||||
u8 cpumode = event->header.misc & PERF_RECORD_MISC_CPUMODE_MASK;
|
||||
struct thread *thread = perf_session__findnew(session, event->ip.pid);
|
||||
|
||||
if (thread == NULL) {
|
||||
pr_err("problem processing %d event, skipping it.\n",
|
||||
event->header.type);
|
||||
return -1;
|
||||
}
|
||||
|
||||
thread__find_addr_map(thread, session, cpumode, MAP__FUNCTION,
|
||||
event->ip.ip, &al);
|
||||
|
||||
if (al.map != NULL)
|
||||
al.map->dso->hit = 1;
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static struct perf_event_ops build_id_list__event_ops = {
|
||||
.sample = build_id_list__process_event,
|
||||
.mmap = event__process_mmap,
|
||||
.fork = event__process_task,
|
||||
};
|
||||
|
||||
static int __cmd_buildid_list(void)
|
||||
{
|
||||
int err = -1;
|
||||
|
@ -71,7 +44,7 @@ static int __cmd_buildid_list(void)
|
|||
return -1;
|
||||
|
||||
if (with_hits)
|
||||
perf_session__process_events(session, &build_id_list__event_ops);
|
||||
perf_session__process_events(session, &build_id__mark_dso_hit_ops);
|
||||
|
||||
dsos__fprintf_buildid(stdout, with_hits);
|
||||
|
||||
|
|
39
tools/perf/util/build-id.c
Normal file
39
tools/perf/util/build-id.c
Normal file
|
@ -0,0 +1,39 @@
|
|||
/*
|
||||
* build-id.c
|
||||
*
|
||||
* build-id support
|
||||
*
|
||||
* Copyright (C) 2009, 2010 Red Hat Inc.
|
||||
* Copyright (C) 2009, 2010 Arnaldo Carvalho de Melo <acme@redhat.com>
|
||||
*/
|
||||
#include "build-id.h"
|
||||
#include "event.h"
|
||||
#include "symbol.h"
|
||||
#include <linux/kernel.h>
|
||||
|
||||
static int build_id__mark_dso_hit(event_t *event, struct perf_session *session)
|
||||
{
|
||||
struct addr_location al;
|
||||
u8 cpumode = event->header.misc & PERF_RECORD_MISC_CPUMODE_MASK;
|
||||
struct thread *thread = perf_session__findnew(session, event->ip.pid);
|
||||
|
||||
if (thread == NULL) {
|
||||
pr_err("problem processing %d event, skipping it.\n",
|
||||
event->header.type);
|
||||
return -1;
|
||||
}
|
||||
|
||||
thread__find_addr_map(thread, session, cpumode, MAP__FUNCTION,
|
||||
event->ip.ip, &al);
|
||||
|
||||
if (al.map != NULL)
|
||||
al.map->dso->hit = 1;
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
struct perf_event_ops build_id__mark_dso_hit_ops = {
|
||||
.sample = build_id__mark_dso_hit,
|
||||
.mmap = event__process_mmap,
|
||||
.fork = event__process_task,
|
||||
};
|
8
tools/perf/util/build-id.h
Normal file
8
tools/perf/util/build-id.h
Normal file
|
@ -0,0 +1,8 @@
|
|||
#ifndef PERF_BUILD_ID_H_
|
||||
#define PERF_BUILD_ID_H_ 1
|
||||
|
||||
#include "session.h"
|
||||
|
||||
extern struct perf_event_ops build_id__mark_dso_hit_ops;
|
||||
|
||||
#endif
|
Loading…
Reference in a new issue