Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

CIFS: Fix variable types in cifs_iovec_read/write (try #2)

Browse source 
Variable 'i' should be unsigned long as it's used in circle with num_pages,
and bytes_read/total_written should be ssize_t according to return value.

Signed-off-by: Pavel Shilovsky <piastry@etersoft.ru>
Reviewed-by: Shirish Pargaonkar <shirishpargaonkar@gmail.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
This commit is contained in:
Pavel Shilovsky 2011-01-31 16:03:08 +03:00 committed by Steve French
parent 9587fcff42
commit 76429c148b
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
fs/cifs/file.c
View file

@ -1662,10 +1662,10 @@ static ssize_t
cifs_iovec_write(struct file *file, const struct iovec *iov, cifs_iovec_write(struct file *file, const struct iovec *iov,
unsigned long nr_segs, loff_t *poffset) unsigned long nr_segs, loff_t *poffset)
{ {
size_t total_written = 0; unsigned int written;
unsigned int written = 0; unsigned long num_pages, npages, i;
unsigned long num_pages, npages; size_t copied, len, cur_len;
size_t copied, len, cur_len, i; ssize_t total_written = 0;
struct kvec *to_send; struct kvec *to_send;
struct page **pages; struct page **pages;
struct iov_iter it; struct iov_iter it;
@ -1821,7 +1821,8 @@ cifs_iovec_read(struct file *file, const struct iovec *iov,
{ {
int rc; int rc;
int xid; int xid;
unsigned int total_read, bytes_read = 0; ssize_t total_read;
unsigned int bytes_read = 0;
size_t len, cur_len; size_t len, cur_len;
int iov_offset = 0; int iov_offset = 0;
struct cifs_sb_info *cifs_sb; struct cifs_sb_info *cifs_sb;