Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

pinctrl: ti-iodelay: remove redundant pin < 0 check on unsigned int

Browse source 
pin is an unsigned int and therefore can never be < 0 so
this check is redundant. Remove the check and the associated
dev_err error message.

Fixes CoverityScan CID#1396438 ("Unsigned compared against 0")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Colin Ian King 2017-01-13 13:20:39 +00:00 committed by Linus Walleij
parent d068b0988a
commit 731d43cd6b
1 changed files with 0 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/pinctrl/ti/pinctrl-ti-iodelay.c
View file

@ -665,12 +665,6 @@ static void ti_iodelay_pin_dbg_show(struct pinctrl_dev *pctldev,
r = iod->reg_data; r = iod->reg_data;
offset = ti_iodelay_pin_to_offset(iod, pin); offset = ti_iodelay_pin_to_offset(iod, pin);
if (pin < 0) {
dev_err(iod->dev, "invalid pin offset for pin%i\n", pin);
return;
}
pd = &iod->pa[pin]; pd = &iod->pa[pin];
cfg = pd->drv_data; cfg = pd->drv_data;