Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

PCI: v3-semi: Fix a memory leak in v3_pci_probe() error handling paths

Browse source 
[ Upstream commit bca718988b9008d0d5f504e2d318178fc84958c1 ]

If we fails somewhere in 'v3_pci_probe()', we need to free 'host'.

Use the managed version of 'pci_alloc_host_bridge()' to do that easily.
The use of managed resources is already widely used in this driver.

Link: https://lore.kernel.org/r/20200418081637.1585-1-christophe.jaillet@wanadoo.fr
Fixes: 68a15eb7bd ("PCI: v3-semi: Add V3 Semiconductor PCI host driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
[lorenzo.pieralisi@arm.com: commit log]
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Christophe JAILLET 2020-04-18 10:16:37 +02:00 committed by Greg Kroah-Hartman
parent a3b8b0a130
commit 7014edf8c0
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/pci/controller/pci-v3-semi.c
View file

@ -743,7 +743,7 @@ static int v3_pci_probe(struct platform_device *pdev)
int ret; int ret;
LIST_HEAD(res); LIST_HEAD(res);
host = pci_alloc_host_bridge(sizeof(*v3)); host = devm_pci_alloc_host_bridge(dev, sizeof(*v3));
if (!host) if (!host)
return -ENOMEM; return -ENOMEM;