Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fakelb: move lock out of iteration

Browse source 
The list need to be protected while iteration which is need when other
list iterates at the same time over this list.

Signed-off-by: Alexander Aring <alex.aring@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
This commit is contained in:
Alexander Aring 2015-05-17 21:45:04 +02:00 • committed by Marcel Holtmann
parent b82b99f16b
commit 6fa2cffe8c
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
drivers/net/ieee802154/fakelb.c
View file

@ -193,9 +193,7 @@ static int fakelb_add_one(struct device *dev)
static void fakelb_del(struct fakelb_phy *phy) static void fakelb_del(struct fakelb_phy *phy)
{ {
write_lock_bh(&fakelb_lock);
list_del(&phy->list); list_del(&phy->list);
write_unlock_bh(&fakelb_lock);
ieee802154_unregister_hw(phy->hw); ieee802154_unregister_hw(phy->hw);
ieee802154_free_hw(phy->hw); ieee802154_free_hw(phy->hw);
@ -217,8 +215,10 @@ static int fakelb_probe(struct platform_device *pdev)
return 0; return 0;
err_slave: err_slave:
write_lock_bh(&fakelb_lock);
list_for_each_entry_safe(phy, tmp, &fakelb_phys, list) list_for_each_entry_safe(phy, tmp, &fakelb_phys, list)
fakelb_del(phy); fakelb_del(phy);
write_unlock_bh(&fakelb_lock);
return err; return err;
} }
@ -226,9 +226,10 @@ static int fakelb_remove(struct platform_device *pdev)
{ {
struct fakelb_phy *phy, *temp; struct fakelb_phy *phy, *temp;
write_lock_bh(&fakelb_lock);
list_for_each_entry_safe(phy, temp, &fakelb_phys, list) list_for_each_entry_safe(phy, temp, &fakelb_phys, list)
fakelb_del(phy); fakelb_del(phy);
write_unlock_bh(&fakelb_lock);
return 0; return 0;
} }