Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[PATCH] Dereference in tokenring/olympic.c

Browse source 
hi,

coverity found (bug id #225) that we might call free_netdev()
with NULL argument, when alloc_trdev() fails. This patch
changes the goto, so we dont call free_netdev() for
dev == NULL.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
This commit is contained in:
Eric Sesterhenn 2006-06-21 16:17:17 +02:00 committed by Jeff Garzik
parent a192491ad5
commit 6d56ab9362
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/net/tokenring/olympic.c
View file

@ -217,7 +217,7 @@ static int __devinit olympic_probe(struct pci_dev *pdev, const struct pci_device
dev = alloc_trdev(sizeof(struct olympic_private)) ;
if (!dev) {
i = -ENOMEM;
goto op_free_dev;
goto op_release_dev;
}
olympic_priv = dev->priv ;
@ -282,8 +282,8 @@ static int __devinit olympic_probe(struct pci_dev *pdev, const struct pci_device
if (olympic_priv->olympic_lap)
iounmap(olympic_priv->olympic_lap);
op_free_dev:
free_netdev(dev);
op_release_dev:
pci_release_regions(pdev);
op_disable_dev: