Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

at86rf230: move RX_SAFE_MODE setting to hw_init

Browse source 
There is no need to set this bit in start callback which could be
called more than once.

Signed-off-by: Alexander Aring <alex.aring@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Alexander Aring 2014-07-03 00:20:49 +02:00 • committed by David S. Miller
parent 1d15d6b5b9
commit 6bd2b132bf
1 changed files with 4 additions and 5 deletions

9
drivers/net/ieee802154/at86rf230.c
View file

@ -1010,13 +1010,8 @@ at86rf230_state(struct ieee802154_dev *dev, int state)
static int
at86rf230_start(struct ieee802154_dev *dev)
{
struct at86rf230_local *lp = dev->priv;
u8 rc;
rc = at86rf230_write_subreg(lp, SR_RX_SAFE_MODE, 1);
if (rc)
return rc;
rc = at86rf230_state(dev, STATE_TX_ON);
if (rc)
return rc;
@ -1300,6 +1295,10 @@ static int at86rf230_hw_init(struct at86rf230_local *lp)
if (rc)
return rc;
rc = at86rf230_write_subreg(lp, SR_RX_SAFE_MODE, 1);
if (rc)
return rc;
rc = at86rf230_write_subreg(lp, SR_IRQ_MASK, IRQ_TRX_END);
if (rc)
return rc;