KVM: Fix off-by-one when writing to a nonpae guest pde
Nonpae guest pdes are shadowed by two pae ptes, so we double the offset twice: once to account for the pte size difference, and once because we need to shadow pdes for a single guest pde. But when writing to the upper guest pde we also need to truncate the lower bits, otherwise the multiply shifts these bits into the pde index and causes an access to the wrong shadow pde. If we're at the end of the page (accessing the very last guest pde) we can even overflow into the next host page and oops. Signed-off-by: Avi Kivity <avi@qumranet.com>
This commit is contained in:
parent
80d74d5123
commit
6b8d0f9b18
1 changed files with 1 additions and 0 deletions
|
@ -1171,6 +1171,7 @@ void kvm_mmu_pre_write(struct kvm_vcpu *vcpu, gpa_t gpa, int bytes)
|
|||
* and zap two pdes instead of one.
|
||||
*/
|
||||
if (level == PT32_ROOT_LEVEL) {
|
||||
page_offset &= ~7; /* kill rounding error */
|
||||
page_offset <<= 1;
|
||||
npte = 2;
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue