Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[PATCH] hci_{read,write}l() does force casts to wrong type for no reason

Browse source 
readl() et.al. expect iomem pointer, so WTF force-cast it to normal one???

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Al Viro 2007-02-09 16:40:00 +00:00 committed by Linus Torvalds
parent 53ebb3b826
commit 68f50e5255
2 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
drivers/usb/host/ehci.h
View file

@ -677,10 +677,10 @@ static inline unsigned int ehci_readl (const struct ehci_hcd *ehci,
{ {
#ifdef CONFIG_USB_EHCI_BIG_ENDIAN_MMIO #ifdef CONFIG_USB_EHCI_BIG_ENDIAN_MMIO
return ehci_big_endian_mmio(ehci) ? return ehci_big_endian_mmio(ehci) ?
readl_be((__force u32 *)regs) : readl_be(regs) :
readl((__force u32 *)regs); readl(regs);
#else #else
return readl((__force u32 *)regs); return readl(regs);
#endif #endif
} }
@ -689,10 +689,10 @@ static inline void ehci_writel (const struct ehci_hcd *ehci,
{ {
#ifdef CONFIG_USB_EHCI_BIG_ENDIAN_MMIO #ifdef CONFIG_USB_EHCI_BIG_ENDIAN_MMIO
ehci_big_endian_mmio(ehci) ? ehci_big_endian_mmio(ehci) ?
writel_be(val, (__force u32 *)regs) : writel_be(val, regs) :
writel(val, (__force u32 *)regs); writel(val, regs);
#else #else
writel(val, (__force u32 *)regs); writel(val, regs);
#endif #endif
} }

12
drivers/usb/host/ohci.h
View file

@ -507,10 +507,10 @@ static inline unsigned int _ohci_readl (const struct ohci_hcd *ohci,
{ {
#ifdef CONFIG_USB_OHCI_BIG_ENDIAN_MMIO #ifdef CONFIG_USB_OHCI_BIG_ENDIAN_MMIO
return big_endian_mmio(ohci) ? return big_endian_mmio(ohci) ?
readl_be ((__force u32 *)regs) : readl_be (regs) :
readl ((__force u32 *)regs); readl (regs);
#else #else
return readl ((__force u32 *)regs); return readl (regs);
#endif #endif
} }
@ -519,10 +519,10 @@ static inline void _ohci_writel (const struct ohci_hcd *ohci,
{ {
#ifdef CONFIG_USB_OHCI_BIG_ENDIAN_MMIO #ifdef CONFIG_USB_OHCI_BIG_ENDIAN_MMIO
big_endian_mmio(ohci) ? big_endian_mmio(ohci) ?
writel_be (val, (__force u32 *)regs) : writel_be (val, regs) :
writel (val, (__force u32 *)regs); writel (val, regs);
#else #else
writel (val, (__force u32 *)regs); writel (val, regs);
#endif #endif
} }