Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

char/tpm/tpm_i2c_stm_st33: Don't use memcpy for one byte assignment

Browse source 
We don't need to call memcpy for one byte, but assign it directly.
And to make the offset clearer we use the array syntax on the subsequent
call to memset to make the relationship clearer.

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Kent Yoder <key@linux.vnet.ibm.com>
This commit is contained in:
Peter Huewe 2013-01-29 22:01:59 +01:00 committed by Kent Yoder
parent d479042c82
commit 64298919ad
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/char/tpm/tpm_i2c_stm_st33.c
View file

@ -96,15 +96,13 @@ enum tis_defaults {
static int write8_reg(struct i2c_client *client, u8 tpm_register,
u8 *tpm_data, u16 tpm_size)
{
u8 data;
int value = 0;
struct st33zp24_platform_data *pin_infos;
pin_infos = client->dev.platform_data;
data = tpm_register;
memcpy(pin_infos->tpm_i2c_buffer[0], &data, sizeof(data));
memcpy(pin_infos->tpm_i2c_buffer[0] + 1, tpm_data, tpm_size);
pin_infos->tpm_i2c_buffer[0][0] = tpm_register;
memcpy(&pin_infos->tpm_i2c_buffer[0][1], tpm_data, tpm_size);
value = i2c_master_send(client, pin_infos->tpm_i2c_buffer[0],
tpm_size + 1);
return value;