Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

gpio: Fix range check in of_gpio_simple_xlate()

Browse source 
of_gpio_simple_xlate() has an off-by-one bug where it checks to see if
args[0] is > ngpio instead of >=.  args[0] must always be less than
ngpio because it is a zero-based enumeration.

Signed-off-by: Roland Stigge <stigge@antcom.de>
[grant.likely: beef up commit text]
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
This commit is contained in:
Roland Stigge 2012-04-04 02:02:58 +02:00 committed by Grant Likely
parent 078dc65e61
commit 6270d830d0
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/of/gpio.c
View file

@ -140,7 +140,7 @@ int of_gpio_simple_xlate(struct gpio_chip *gc,
if (WARN_ON(gpiospec->args_count < gc->of_gpio_n_cells)) if (WARN_ON(gpiospec->args_count < gc->of_gpio_n_cells))
return -EINVAL; return -EINVAL;
if (gpiospec->args[0] > gc->ngpio) if (gpiospec->args[0] >= gc->ngpio)
return -EINVAL; return -EINVAL;
if (flags) if (flags)