Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

KVM: correct error-handling code

Browse source 
This code is not executed before file has been initialized to the result of
calling eventfd_fget.  This function returns an ERR_PTR value in an error
case instead of NULL.  Thus the test that file is not NULL is always true.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@match exists@
expression x, E;
statement S1, S2;
@@

x = eventfd_fget(...)
... when != x = E
(
*  if (x == NULL || ...) S1 else S2
|
*  if (x == NULL && ...) S1 else S2
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Avi Kivity <avi@redhat.com>
This commit is contained in:
Julia Lawall 2009-07-28 17:53:24 +02:00 committed by Avi Kivity
parent 28bcb11218
commit 6223011fb9
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
virt/kvm/eventfd.c
View file

@ -230,7 +230,7 @@ kvm_irqfd_assign(struct kvm *kvm, int fd, int gsi)
if (eventfd && !IS_ERR(eventfd))
eventfd_ctx_put(eventfd);
if (file && !IS_ERR(file))
if (!IS_ERR(file))
fput(file);
kfree(irqfd);