Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

orangefs: Use kcalloc() in orangefs_prepare_cdm_array()

Browse source 
* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kcalloc".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data structure by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
This commit is contained in:
Markus Elfring 2017-08-17 21:18:01 +02:00 committed by Mike Marshall
parent 07a258531c
commit 5e273a0e06
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
fs/orangefs/orangefs-debugfs.c
View file

@ -571,9 +571,7 @@ static int orangefs_prepare_cdm_array(char *debug_array_string)
goto out;
}
cdm_array =
kzalloc(cdm_element_count * sizeof(struct client_debug_mask),
GFP_KERNEL);
cdm_array = kcalloc(cdm_element_count, sizeof(*cdm_array), GFP_KERNEL);
if (!cdm_array) {
rc = -ENOMEM;
goto out;