Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

net: fib_rules ordering fixes.

Browse source 
We need to setup the network namespace state before we register
the notifier.  Otherwise if a network device is already registered
we get a nasty NULL pointer dereference.

Signed-off-by: Eric W. Biederman <ebiederm@maxwell.aristanetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Eric W. Biederman 2008-11-07 22:52:34 -08:00 committed by David S. Miller
parent 3d8160b149
commit 5d6d480908
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
net/core/fib_rules.c
View file

@ -664,17 +664,18 @@ static int __init fib_rules_init(void)
rtnl_register(PF_UNSPEC, RTM_DELRULE, fib_nl_delrule, NULL); rtnl_register(PF_UNSPEC, RTM_DELRULE, fib_nl_delrule, NULL);
rtnl_register(PF_UNSPEC, RTM_GETRULE, NULL, fib_nl_dumprule); rtnl_register(PF_UNSPEC, RTM_GETRULE, NULL, fib_nl_dumprule);
err = register_netdevice_notifier(&fib_rules_notifier); err = register_pernet_subsys(&fib_rules_net_ops);
if (err < 0) if (err < 0)
goto fail; goto fail;
err = register_pernet_subsys(&fib_rules_net_ops); err = register_netdevice_notifier(&fib_rules_notifier);
if (err < 0) if (err < 0)
goto fail_unregister; goto fail_unregister;
return 0; return 0;
fail_unregister: fail_unregister:
unregister_netdevice_notifier(&fib_rules_notifier); unregister_pernet_subsys(&fib_rules_net_ops);
fail: fail:
rtnl_unregister(PF_UNSPEC, RTM_NEWRULE); rtnl_unregister(PF_UNSPEC, RTM_NEWRULE);
rtnl_unregister(PF_UNSPEC, RTM_DELRULE); rtnl_unregister(PF_UNSPEC, RTM_DELRULE);