[SCSI] qla2xxx: Return a FAILED status when abort mailbox-command fails.
Mike Reed noted (https://bugzilla.novell.com/show_bug.cgi?id=421330) that the driver was incorrectly returning a SUCCESS status if the driver's request to the firmware to abort a command failed. By doing so, the mid-layer believed, incorrectly, that the command has completed and has been returned (ultimately clearing scsi_cmnd.request_buffer) yet the driver still has the command. What should correctly happen is a mid-layer escalation (device-reset, etc.) of recovery during which the driver will eventually return the outstanding commands to the mid-layer. Cc: Stable Tree <stable@kernel.org> Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
This commit is contained in:
parent
680d7db88a
commit
5bff55db3d
1 changed files with 1 additions and 0 deletions
|
@ -728,6 +728,7 @@ qla2xxx_eh_abort(struct scsi_cmnd *cmd)
|
|||
if (ha->isp_ops->abort_command(ha, sp)) {
|
||||
DEBUG2(printk("%s(%ld): abort_command "
|
||||
"mbx failed.\n", __func__, ha->host_no));
|
||||
ret = FAILED;
|
||||
} else {
|
||||
DEBUG3(printk("%s(%ld): abort_command "
|
||||
"mbx success.\n", __func__, ha->host_no));
|
||||
|
|
Loading…
Reference in a new issue