revert "rtc: recycle id when unloading a rtc driver"
Revert commit2830a6d201
. We already perform the ida_simple_remove() in rtc_device_release(), which is an appropriate place. Commit2830a6d20
("rtc: recycle id when unloading a rtc driver") caused the kernel to emit ida_remove called for id=0 which is not allocated. warnings when rtc_device_release() tries to release an alread-released ID. Let's restore things to their previous state and then work out why Vincent's kernel wasn't calling rtc_device_release() - presumably a bug in a specific sub-driver. Reported-by: Lothar Waßmann <LW@KARO-electronics.de> Acked-by: Alexander Holler <holler@ahsoftware.de> Cc: Vincent Palatin <vpalatin@chromium.org> Cc: <stable@vger.kernel.org> [3.7.x] Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
2c79737af8
commit
5abe257af8
1 changed files with 0 additions and 1 deletions
|
@ -244,7 +244,6 @@ void rtc_device_unregister(struct rtc_device *rtc)
|
|||
rtc_proc_del_device(rtc);
|
||||
device_unregister(&rtc->dev);
|
||||
rtc->ops = NULL;
|
||||
ida_simple_remove(&rtc_ida, rtc->id);
|
||||
mutex_unlock(&rtc->ops_lock);
|
||||
put_device(&rtc->dev);
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue