Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

ALSA: sparc/cs4231: Use WARN_ON() instead of BUG_ON()

Browse source 
BUG_ON() is rather useless for debugging as it leads to panic().
Use WARN_ON() and handle the error cases accordingly.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Takashi Iwai 2013-11-05 15:02:42 +01:00
parent 025be74c1d
commit 5a19b178d7
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
sound/sparc/cs4231.c
View file

@ -429,7 +429,8 @@ static void snd_cs4231_advance_dma(struct cs4231_dma_control *dma_cont,
unsigned int period_size = snd_pcm_lib_period_bytes(substream); unsigned int period_size = snd_pcm_lib_period_bytes(substream);
unsigned int offset = period_size * (*periods_sent); unsigned int offset = period_size * (*periods_sent);
BUG_ON(period_size >= (1 << 24)); if (WARN_ON(period_size >= (1 << 24)))
return;
if (dma_cont->request(dma_cont, if (dma_cont->request(dma_cont,
runtime->dma_addr + offset, period_size)) runtime->dma_addr + offset, period_size))
@ -912,7 +913,8 @@ static int snd_cs4231_playback_prepare(struct snd_pcm_substream *substream)
chip->image[CS4231_IFACE_CTRL] &= ~(CS4231_PLAYBACK_ENABLE | chip->image[CS4231_IFACE_CTRL] &= ~(CS4231_PLAYBACK_ENABLE |
CS4231_PLAYBACK_PIO); CS4231_PLAYBACK_PIO);
BUG_ON(runtime->period_size > 0xffff + 1); if (WARN_ON(runtime->period_size > 0xffff + 1))
return -EINVAL;
chip->p_periods_sent = 0; chip->p_periods_sent = 0;
spin_unlock_irqrestore(&chip->lock, flags); spin_unlock_irqrestore(&chip->lock, flags);