Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[POWERPC] cell: hard disable interrupts in power_save()

Browse source 
With soft-disabled interrupts in power_save, we can
still get external exceptions on Cell, even if we are
in pause(0) a.k.a. sleep state.

When the CPU really wakes up through the 0x100 (system reset)
vector, while we have already started processing the 0x500
(external) exception, we get a panic in unrecoverable_exception()
because of the lost state.

This occurred in Systemsim for Cell, but as far as I can see,
it can theoretically occur on any machine that uses the
system reset exception to get out of sleep state.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Arnd Bergmann <arnd.bergmann@de.ibm.com>
This commit is contained in:
Benjamin Herrenschmidt 2006-11-23 00:46:38 +01:00 committed by Paul Mackerras
parent bf1ab978be
commit 5850dd8f6d
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
arch/powerpc/platforms/cell/pervasive.c
View file

@ -41,6 +41,15 @@
static void cbe_power_save(void)
{
unsigned long ctrl, thread_switch_control;
/*
* We need to hard disable interrupts, but we also need to mark them
* hard disabled in the PACA so that the local_irq_enable() done by
* our caller upon return propertly hard enables.
*/
hard_irq_disable();
get_paca()->hard_enabled = 0;
ctrl = mfspr(SPRN_CTRLF);
/* Enable DEC and EE interrupt request */