Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

phylib: unsigneds go unnoticed

Browse source 
both pdata->mdc and pdata->mdio are unsigned. Notice a negative
return value.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Roel Kluin 2009-01-19 17:14:21 -08:00 committed by David S. Miller
parent 9f4d26d0f3
commit 57a574993d
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
drivers/net/phy/mdio-gpio.c
View file

@ -200,16 +200,21 @@ static int __devinit mdio_ofgpio_probe(struct of_device *ofdev,
{
struct device_node *np = NULL;
struct mdio_gpio_platform_data *pdata;
int ret;
pdata = kzalloc(sizeof(*pdata), GFP_KERNEL);
if (!pdata)
return -ENOMEM;
pdata->mdc = of_get_gpio(ofdev->node, 0);
pdata->mdio = of_get_gpio(ofdev->node, 1);
if (pdata->mdc < 0 || pdata->mdio < 0)
ret = of_get_gpio(ofdev->node, 0);
if (ret < 0)
goto out_free;
pdata->mdc = ret;
ret = of_get_gpio(ofdev->node, 1);
if (ret < 0)
goto out_free;
pdata->mdio = ret;
while ((np = of_get_next_child(ofdev->node, np)))
if (!strcmp(np->type, "ethernet-phy"))