Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

of: Change of_device_is_available() to return bool

Browse source 
This function can only return true or false; using a bool makes it more
obvious to the reader.

Signed-off-by: Kevin Cernekee <cernekee@gmail.com>
Signed-off-by: Grant Likely <grant.likely@linaro.org>
This commit is contained in:
Kevin Cernekee 2014-11-12 12:54:01 -08:00 committed by Grant Likely
parent 25c7a1de6c
commit 53a4ab96c6
2 changed files with 14 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
drivers/of/base.c
View file

@ -522,27 +522,27 @@ EXPORT_SYMBOL(of_machine_is_compatible);
* *
* @device: Node to check for availability, with locks already held * @device: Node to check for availability, with locks already held
* *
* Returns 1 if the status property is absent or set to "okay" or "ok", * Returns true if the status property is absent or set to "okay" or "ok",
* 0 otherwise * false otherwise
*/ */
static int __of_device_is_available(const struct device_node *device) static bool __of_device_is_available(const struct device_node *device)
{ {
const char *status; const char *status;
int statlen; int statlen;
if (!device) if (!device)
return 0; return false;
status = __of_get_property(device, "status", &statlen); status = __of_get_property(device, "status", &statlen);
if (status == NULL) if (status == NULL)
return 1; return true;
if (statlen > 0) { if (statlen > 0) {
if (!strcmp(status, "okay") || !strcmp(status, "ok")) if (!strcmp(status, "okay") || !strcmp(status, "ok"))
return 1; return true;
} }
return 0; return false;
} }
/** /**
@ -550,13 +550,13 @@ static int __of_device_is_available(const struct device_node *device)
* *
* @device: Node to check for availability * @device: Node to check for availability
* *
* Returns 1 if the status property is absent or set to "okay" or "ok", * Returns true if the status property is absent or set to "okay" or "ok",
* 0 otherwise * false otherwise
*/ */
int of_device_is_available(const struct device_node *device) bool of_device_is_available(const struct device_node *device)
{ {
unsigned long flags; unsigned long flags;
int res; bool res;
raw_spin_lock_irqsave(&devtree_lock, flags); raw_spin_lock_irqsave(&devtree_lock, flags);
res = __of_device_is_available(device); res = __of_device_is_available(device);

6
include/linux/of.h
View file

@ -276,7 +276,7 @@ extern int of_property_read_string_helper(struct device_node *np,
const char **out_strs, size_t sz, int index); const char **out_strs, size_t sz, int index);
extern int of_device_is_compatible(const struct device_node *device, extern int of_device_is_compatible(const struct device_node *device,
const char *); const char *);
extern int of_device_is_available(const struct device_node *device); extern bool of_device_is_available(const struct device_node *device);
extern const void *of_get_property(const struct device_node *node, extern const void *of_get_property(const struct device_node *node,
const char *name, const char *name,
int *lenp); int *lenp);
@ -427,9 +427,9 @@ static inline int of_device_is_compatible(const struct device_node *device,
return 0; return 0;
} }
static inline int of_device_is_available(const struct device_node *device) static inline bool of_device_is_available(const struct device_node *device)
{ {
return 0; return false;
} }
static inline struct property *of_find_property(const struct device_node *np, static inline struct property *of_find_property(const struct device_node *np,