Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

sysfs: Kill nlink counting.

Browse source 
Tracking the number of subdirectories requires an extra field that increases
the size of sysfs_dirent.  nlinks are not particularly interesting for sysfs
and the nlink counts are wrong when network namespaces are involved so stop
counting them, and always return nlink == 1.  Userspace already knows that
directories with nlink == 1 have an nlink count they can't use to count
subdirectories.

This reduces the size of sysfs_dirent by 8 bytes on 64bit platforms.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Eric W. Biederman 2011-12-18 20:09:31 -08:00 • committed by Greg Kroah-Hartman
parent cafa6b5dd7
commit 524b6c5b39
3 changed files with 0 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
fs/sysfs/dir.c
View file

@ -91,9 +91,6 @@ static int sysfs_link_sibling(struct sysfs_dirent *sd)
struct rb_node **node = &sd->s_parent->s_dir.children.rb_node; struct rb_node **node = &sd->s_parent->s_dir.children.rb_node;
struct rb_node *parent = NULL; struct rb_node *parent = NULL;
if (sysfs_type(sd) == SYSFS_DIR)
sd->s_parent->s_dir.subdirs++;
while (*node) { while (*node) {
struct sysfs_dirent *pos; struct sysfs_dirent *pos;
int result; int result;
@ -126,9 +123,6 @@ static int sysfs_link_sibling(struct sysfs_dirent *sd)
*/ */
static void sysfs_unlink_sibling(struct sysfs_dirent *sd) static void sysfs_unlink_sibling(struct sysfs_dirent *sd)
{ {
if (sysfs_type(sd) == SYSFS_DIR)
sd->s_parent->s_dir.subdirs--;
rb_erase(&sd->s_rb, &sd->s_parent->s_dir.children); rb_erase(&sd->s_rb, &sd->s_parent->s_dir.children);
} }

3
fs/sysfs/inode.c
View file

@ -216,9 +216,6 @@ static void sysfs_refresh_inode(struct sysfs_dirent *sd, struct inode *inode)
iattrs->ia_secdata, iattrs->ia_secdata,
iattrs->ia_secdata_len); iattrs->ia_secdata_len);
} }
if (sysfs_type(sd) == SYSFS_DIR)
set_nlink(inode, sd->s_dir.subdirs + 2);
} }
int sysfs_getattr(struct vfsmount *mnt, struct dentry *dentry, struct kstat *stat) int sysfs_getattr(struct vfsmount *mnt, struct dentry *dentry, struct kstat *stat)

1
fs/sysfs/sysfs.h
View file

@ -19,7 +19,6 @@ struct sysfs_open_dirent;
struct sysfs_elem_dir { struct sysfs_elem_dir {
struct kobject *kobj; struct kobject *kobj;
unsigned long subdirs;
/* children rbtree starts here and goes through sd->s_rb */ /* children rbtree starts here and goes through sd->s_rb */
struct rb_root children; struct rb_root children;
}; };