Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

coccicheck: return proper error code on fail

Browse source 
If coccicheck fails, it should return an error code distinct from zero
to signal about an internal problem. Current code instead of exiting with
the tool's error code returns the error code of 'echo "coccicheck failed"'
which is almost always equals to zero, thus failing the original intention
of alerting about a problem. This patch fixes the code.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Denis Efremov <efremov@linux.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
This commit is contained in:
Denis Efremov 2018-08-10 23:25:55 +03:00 committed by Masahiro Yamada
parent 09d4d9648b
commit 512ddf7d7d
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
scripts/coccicheck
View file

@ -128,9 +128,10 @@ run_cmd_parmap() {
fi fi
echo $@ >>$DEBUG_FILE echo $@ >>$DEBUG_FILE
$@ 2>>$DEBUG_FILE $@ 2>>$DEBUG_FILE
if [[ $? -ne 0 ]]; then err=$?
if [[ $err -ne 0 ]]; then
echo "coccicheck failed" echo "coccicheck failed"
exit $? exit $err
fi fi
} }