Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[PATCH] tclk: fix typos, exclamation mark frenzy and missing device id on messages

Browse source 
I sent this out a couple of months ago and the driver author said it
he'd merge it. Nothing has happened since so I'm submitting it directly.

No functionality changes just texts.

Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Alan Cox 2006-01-11 12:17:33 -08:00 committed by Linus Torvalds
parent b7599587fa
commit 4ab2495a30
1 changed files with 7 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
drivers/char/tlclk.c
View file

@ -211,7 +211,7 @@ static int tlclk_open(struct inode *inode, struct file *filp)
result = request_irq(telclk_interrupt, &tlclk_interrupt, result = request_irq(telclk_interrupt, &tlclk_interrupt,
SA_INTERRUPT, "telco_clock", tlclk_interrupt); SA_INTERRUPT, "telco_clock", tlclk_interrupt);
if (result == -EBUSY) { if (result == -EBUSY) {
printk(KERN_ERR "telco_clock: Interrupt can't be reserved!\n"); printk(KERN_ERR "tlclk: Interrupt can't be reserved.\n");
return -EBUSY; return -EBUSY;
} }
inb(TLCLK_REG6); /* Clear interrupt events */ inb(TLCLK_REG6); /* Clear interrupt events */
@ -741,7 +741,7 @@ static int __init tlclk_init(void)
ret = register_chrdev(tlclk_major, "telco_clock", &tlclk_fops); ret = register_chrdev(tlclk_major, "telco_clock", &tlclk_fops);
if (ret < 0) { if (ret < 0) {
printk(KERN_ERR "telco_clock: can't get major! %d\n", tlclk_major); printk(KERN_ERR "tlclk: can't get major %d.\n", tlclk_major);
return ret; return ret;
} }
alarm_events = kzalloc( sizeof(struct tlclk_alarms), GFP_KERNEL); alarm_events = kzalloc( sizeof(struct tlclk_alarms), GFP_KERNEL);
@ -750,7 +750,7 @@ static int __init tlclk_init(void)
/* Read telecom clock IRQ number (Set by BIOS) */ /* Read telecom clock IRQ number (Set by BIOS) */
if (!request_region(TLCLK_BASE, 8, "telco_clock")) { if (!request_region(TLCLK_BASE, 8, "telco_clock")) {
printk(KERN_ERR "tlclk: request_region failed! 0x%X\n", printk(KERN_ERR "tlclk: request_region 0x%X failed.\n",
TLCLK_BASE); TLCLK_BASE);
ret = -EBUSY; ret = -EBUSY;
goto out2; goto out2;
@ -758,7 +758,7 @@ static int __init tlclk_init(void)
telclk_interrupt = (inb(TLCLK_REG7) & 0x0f); telclk_interrupt = (inb(TLCLK_REG7) & 0x0f);
if (0x0F == telclk_interrupt ) { /* not MCPBL0010 ? */ if (0x0F == telclk_interrupt ) { /* not MCPBL0010 ? */
printk(KERN_ERR "telclk_interrup = 0x%x non-mcpbl0010 hw\n", printk(KERN_ERR "telclk_interrup = 0x%x non-mcpbl0010 hw.\n",
telclk_interrupt); telclk_interrupt);
ret = -ENXIO; ret = -ENXIO;
goto out3; goto out3;
@ -768,7 +768,7 @@ static int __init tlclk_init(void)
ret = misc_register(&tlclk_miscdev); ret = misc_register(&tlclk_miscdev);
if (ret < 0) { if (ret < 0) {
printk(KERN_ERR " misc_register retruns %d\n", ret); printk(KERN_ERR "tlclk: misc_register returns %d.\n", ret);
ret = -EBUSY; ret = -EBUSY;
goto out3; goto out3;
} }
@ -776,8 +776,7 @@ static int __init tlclk_init(void)
tlclk_device = platform_device_register_simple("telco_clock", tlclk_device = platform_device_register_simple("telco_clock",
-1, NULL, 0); -1, NULL, 0);
if (!tlclk_device) { if (!tlclk_device) {
printk(KERN_ERR " platform_device_register retruns 0x%X\n", printk(KERN_ERR "tlclk: platform_device_register failed.\n");
(unsigned int) tlclk_device);
ret = -EBUSY; ret = -EBUSY;
goto out4; goto out4;
} }
@ -785,7 +784,7 @@ static int __init tlclk_init(void)
ret = sysfs_create_group(&tlclk_device->dev.kobj, ret = sysfs_create_group(&tlclk_device->dev.kobj,
&tlclk_attribute_group); &tlclk_attribute_group);
if (ret) { if (ret) {
printk(KERN_ERR "failed to create sysfs device attributes\n"); printk(KERN_ERR "tlclk: failed to create sysfs device attributes.\n");
sysfs_remove_group(&tlclk_device->dev.kobj, sysfs_remove_group(&tlclk_device->dev.kobj,
&tlclk_attribute_group); &tlclk_attribute_group);
goto out5; goto out5;