coccinelle: semantic patch to check for PTR_ERR after reassignment
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Michal Marek <mmarek@suse.cz>
This commit is contained in:
parent
47f67ea902
commit
4a05f06752
1 changed files with 41 additions and 0 deletions
41
scripts/coccinelle/misc/cstptr.cocci
Normal file
41
scripts/coccinelle/misc/cstptr.cocci
Normal file
|
@ -0,0 +1,41 @@
|
||||||
|
/// PTR_ERR should be applied before its argument is reassigned, typically
|
||||||
|
/// to NULL
|
||||||
|
///
|
||||||
|
// Confidence: High
|
||||||
|
// Copyright: (C) 2012 Julia Lawall, INRIA/LIP6. GPLv2.
|
||||||
|
// Copyright: (C) 2012 Gilles Muller, INRIA/LiP6. GPLv2.
|
||||||
|
// URL: http://coccinelle.lip6.fr/
|
||||||
|
// Comments:
|
||||||
|
// Options: -no_includes -include_headers
|
||||||
|
|
||||||
|
virtual org
|
||||||
|
virtual report
|
||||||
|
virtual context
|
||||||
|
|
||||||
|
@r exists@
|
||||||
|
expression e,e1;
|
||||||
|
constant c;
|
||||||
|
position p1,p2;
|
||||||
|
@@
|
||||||
|
|
||||||
|
*e@p1 = c
|
||||||
|
... when != e = e1
|
||||||
|
when != &e
|
||||||
|
when != true IS_ERR(e)
|
||||||
|
*PTR_ERR@p2(e)
|
||||||
|
|
||||||
|
@script:python depends on org@
|
||||||
|
p1 << r.p1;
|
||||||
|
p2 << r.p2;
|
||||||
|
@@
|
||||||
|
|
||||||
|
cocci.print_main("PTR_ERR",p2)
|
||||||
|
cocci.print_secs("assignment",p1)
|
||||||
|
|
||||||
|
@script:python depends on report@
|
||||||
|
p1 << r.p1;
|
||||||
|
p2 << r.p2;
|
||||||
|
@@
|
||||||
|
|
||||||
|
msg = "ERROR: PTR_ERR applied after initialization to constant on line %s" % (p1[0].line)
|
||||||
|
coccilib.report.print_report(p2[0],msg)
|
Loading…
Reference in a new issue