Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge branch 'hsi-fixes'

Browse source 
huangdaode says:

====================
net: hisilicon fix some bugs in HNS drivers

This patchset fixes the two bugs in HNS driver, one is remove the hnae sysfs interface
according to the review comments from Arnd Bergmann <arnd@arndb.de>, another
is fixing the wrong mac_id judgement bug which is found during internal tests.

change log:
v3:
 remove the hnae sysfs interface.

v2:
  1) remove first bug fix, which is fixed in another patch submitted by
     Arnd Bergmann <arnd@arndb.de>
  2) change the code sytyle according to Joe.

v1:
 initial version.
====================

Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
David S. Miller 2015-10-18 19:54:45 -07:00
commit 4639a3b522
2 changed files with 1 additions and 48 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

47
drivers/net/ethernet/hisilicon/hns/hnae.c
View file

@ -436,59 +436,12 @@ void hnae_ae_unregister(struct hnae_ae_dev *hdev)
} }
EXPORT_SYMBOL(hnae_ae_unregister); EXPORT_SYMBOL(hnae_ae_unregister);
static ssize_t handles_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
ssize_t s = 0;
struct hnae_ae_dev *hdev = cls_to_ae_dev(dev);
struct hnae_handle *h;
int i = 0, j;
list_for_each_entry_rcu(h, &hdev->handle_list, node) {
s += sprintf(buf + s, "handle %d (eport_id=%u from %s):\n",
i++, h->eport_id, h->dev->name);
for (j = 0; j < h->q_num; j++) {
s += sprintf(buf + s, "\tqueue[%d] on %p\n",
j, h->qs[i]->io_base);
#define HANDEL_TX_MSG "\t\ttx_ring on %p:%u,%u,%u,%u,%u,%llu,%llu\n"
s += sprintf(buf + s,
HANDEL_TX_MSG,
h->qs[i]->tx_ring.io_base,
h->qs[i]->tx_ring.buf_size,
h->qs[i]->tx_ring.desc_num,
h->qs[i]->tx_ring.max_desc_num_per_pkt,
h->qs[i]->tx_ring.max_raw_data_sz_per_desc,
h->qs[i]->tx_ring.max_pkt_size,
h->qs[i]->tx_ring.stats.sw_err_cnt,
h->qs[i]->tx_ring.stats.io_err_cnt);
s += sprintf(buf + s,
"\t\trx_ring on %p:%u,%u,%llu,%llu,%llu\n",
h->qs[i]->rx_ring.io_base,
h->qs[i]->rx_ring.buf_size,
h->qs[i]->rx_ring.desc_num,
h->qs[i]->rx_ring.stats.sw_err_cnt,
h->qs[i]->rx_ring.stats.io_err_cnt,
h->qs[i]->rx_ring.stats.seg_pkt_cnt);
}
}
return s;
}
static DEVICE_ATTR_RO(handles);
static struct attribute *hnae_class_attrs[] = {
&dev_attr_handles.attr,
NULL,
};
ATTRIBUTE_GROUPS(hnae_class);
static int __init hnae_init(void) static int __init hnae_init(void)
{ {
hnae_class = class_create(THIS_MODULE, "hnae"); hnae_class = class_create(THIS_MODULE, "hnae");
if (IS_ERR(hnae_class)) if (IS_ERR(hnae_class))
return PTR_ERR(hnae_class); return PTR_ERR(hnae_class);
hnae_class->dev_groups = hnae_class_groups;
return 0; return 0;
} }

2
drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
View file

@ -179,7 +179,7 @@ static int hns_mac_get_inner_port_num(struct hns_mac_cb *mac_cb,
return -EINVAL; return -EINVAL;
} }
} else if (mac_cb->dsaf_dev->dsaf_mode < DSAF_MODE_MAX) { } else if (mac_cb->dsaf_dev->dsaf_mode < DSAF_MODE_MAX) {
if (mac_cb->mac_id <= DSAF_MAX_PORT_NUM_PER_CHIP) { if (mac_cb->mac_id >= DSAF_MAX_PORT_NUM_PER_CHIP) {
dev_err(mac_cb->dev, dev_err(mac_cb->dev,
"input invalid,%s mac%d vmid%d!\n", "input invalid,%s mac%d vmid%d!\n",
mac_cb->dsaf_dev->ae_dev.name, mac_cb->dsaf_dev->ae_dev.name,