Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

ocfs2: one function call less in user_cluster_connect() after error detection

Browse source 
kfree() was called by user_cluster_connect() even if a previous call of
the kzalloc() function failed.

Return from this implementation directly after failure detection.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Joel Becker <jlbec@evilplan.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Markus Elfring 2015-04-14 15:42:59 -07:00 committed by Linus Torvalds
parent bb34ed21bc
commit 43ee9cad8a
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
fs/ocfs2/stack_user.c
View file

@ -1004,10 +1004,8 @@ static int user_cluster_connect(struct ocfs2_cluster_connection *conn)
BUG_ON(conn == NULL); BUG_ON(conn == NULL);
lc = kzalloc(sizeof(struct ocfs2_live_connection), GFP_KERNEL); lc = kzalloc(sizeof(struct ocfs2_live_connection), GFP_KERNEL);
if (!lc) { if (!lc)
rc = -ENOMEM; return -ENOMEM;
goto out;
}
init_waitqueue_head(&lc->oc_wait); init_waitqueue_head(&lc->oc_wait);
init_completion(&lc->oc_sync_wait); init_completion(&lc->oc_sync_wait);